Skip to content

Conversation

@Gijsreyn
Copy link
Contributor

No description provided.

@prmerger-automator
Copy link
Contributor

@Gijsreyn : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 62bc94c:

⚠️ Validation status: warnings

File Status Preview URL Details
hub/powertoys/dsc-configure/microsoft-dsc.md ⚠️Warning Details
hub/powertoys/dsc-configure/psdsc.md ⚠️Warning Details
hub/powertoys/dsc-configure/overview.md 💡Suggestion Details

hub/powertoys/dsc-configure/microsoft-dsc.md

  • Line 356, Column 1: [Warning: file-not-found - See documentation] Invalid file link: '../../../dsc/overview.md'.
  • Line 408, Column 3: [Warning: file-not-found - See documentation] Invalid file link: '../../../dsc/overview.md'.
  • Line 0, Column 0: [Suggestion: filename-incomplete - See documentation] The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.
  • Line 410, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/powershell/dsc/overview' will be broken in isolated environments. Replace with a relative link.
  • Line 411, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/windows/package-manager/configuration/' will be broken in isolated environments. Replace with a relative link.

hub/powertoys/dsc-configure/psdsc.md

  • Line 631, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'index.md'.
  • Line 0, Column 0: [Suggestion: filename-incomplete - See documentation] The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.
  • Line 38, Column 16: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/powershell/dsc/overview' will be broken in isolated environments. Replace with a relative link.
  • Line 634, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/windows/package-manager/configuration/' will be broken in isolated environments. Replace with a relative link.
  • Line 635, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/powershell/dsc/overview' will be broken in isolated environments. Replace with a relative link.

hub/powertoys/dsc-configure/overview.md

  • Line 120, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/windows/package-manager/configuration/' will be broken in isolated environments. Replace with a relative link.
  • Line 121, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/powershell/dsc/overview' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

Copy link
Contributor

@alvinashcraft alvinashcraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments added to fix the build warnings and suggestions. There's already a dsc-configure.md file in the powertoys folder. Are you planning to remove that or link to these files from there? Also, make sure you add or update any links the mention DSC in the powertoys install.md file. Also, the new files need to be added to the table of contents in the ..\dev-environment\toc.yml file.

@alvinashcraft
Copy link
Contributor

Thanks for creating this draft PR! I added some comments to address while you're working on it.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit e2d6e3e:

💡 Validation status: suggestions

File Status Preview URL Details
hub/powertoys/dsc-configure/microsoft-dsc.md 💡Suggestion Details
hub/powertoys/dsc-configure/psdsc.md 💡Suggestion Details
hub/powertoys/dsc-configure/overview.md ✅Succeeded

hub/powertoys/dsc-configure/microsoft-dsc.md

  • Line 0, Column 0: [Suggestion: filename-incomplete - See documentation] The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

hub/powertoys/dsc-configure/psdsc.md

  • Line 0, Column 0: [Suggestion: filename-incomplete - See documentation] The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.

@Gijsreyn
Copy link
Contributor Author

Some comments added to fix the build warnings and suggestions. There's already a dsc-configure.md file in the powertoys folder. Are you planning to remove that or link to these files from there? Also, make sure you add or update any links the mention DSC in the powertoys install.md file. Also, the new files need to be added to the table of contents in the ..\dev-environment\toc.yml file.

My intention was to remove this file and refer to the new dsc-configure folder. I have done so now.

@Gijsreyn Gijsreyn marked this pull request as ready for review October 20, 2025 23:35
@Gijsreyn
Copy link
Contributor Author

Thanks for creating this draft PR! I added some comments to address while you're working on it.

Thanks for the review Alvin! I think I've captured all your feedback (the first round). Mind taking another stab at it and share your thoughts on referencing to the other repo :)

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 18ec947:

💡 Validation status: suggestions

File Status Preview URL Details
hub/powertoys/dsc-configure/microsoft-dsc.md 💡Suggestion Details
hub/powertoys/dsc-configure/psdsc.md 💡Suggestion Details
hub/dev-environment/toc.yml ✅Succeeded
hub/powertoys/dsc-configure.md ✅Succeeded n/a (file deleted or renamed)
hub/powertoys/dsc-configure/overview.md ✅Succeeded
hub/powertoys/install.md ✅Succeeded

hub/powertoys/dsc-configure/microsoft-dsc.md

  • Line 0, Column 0: [Suggestion: filename-incomplete - See documentation] The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

hub/powertoys/dsc-configure/psdsc.md

  • Line 0, Column 0: [Suggestion: filename-incomplete - See documentation] The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Deleted File(s) This PR deletes Markdown or YAML files owned by another author, or json file(s). The pull request must contain a comment from the pull request author confirming that all the file deletions are intentional before the pull request can be merged.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

@alvinashcraft alvinashcraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than some formatting (removing extra line breaks), this looks good to me. If there's someone else familiar with DSC who can review it from a technical standpoint, that would be great. Maybe have @niels9001 take a look too, so we're sure the structure fits with his vision of where the PT docs should be going.

@alvinashcraft alvinashcraft self-requested a review October 21, 2025 14:50
@taetubol626-oss
Copy link

description provided. And merge it and pull request send code

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 12933b5:

💡 Validation status: suggestions

File Status Preview URL Details
hub/powertoys/dsc-configure/microsoft-dsc.md 💡Suggestion Details
hub/powertoys/dsc-configure/psdsc.md 💡Suggestion Details
hub/dev-environment/toc.yml ✅Succeeded
hub/powertoys/dsc-configure.md ✅Succeeded n/a (file deleted or renamed)
hub/powertoys/dsc-configure/overview.md ✅Succeeded
hub/powertoys/install.md ✅Succeeded

hub/powertoys/dsc-configure/microsoft-dsc.md

  • Line 0, Column 0: [Suggestion: filename-incomplete - See documentation] The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

hub/powertoys/dsc-configure/psdsc.md

  • Line 0, Column 0: [Suggestion: filename-incomplete - See documentation] The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Deleted File(s) This PR deletes Markdown or YAML files owned by another author, or json file(s). The pull request must contain a comment from the pull request author confirming that all the file deletions are intentional before the pull request can be merged.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 35f11aa:

💡 Validation status: suggestions

File Status Preview URL Details
hub/powertoys/dsc-configure/microsoft-dsc.md 💡Suggestion Details
hub/powertoys/dsc-configure/psdsc.md 💡Suggestion Details
hub/dev-environment/toc.yml ✅Succeeded
hub/powertoys/dsc-configure.md ✅Succeeded n/a (file deleted or renamed)
hub/powertoys/dsc-configure/overview.md ✅Succeeded
hub/powertoys/install.md ✅Succeeded

hub/powertoys/dsc-configure/microsoft-dsc.md

  • Line 0, Column 0: [Suggestion: filename-incomplete - See documentation] The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

hub/powertoys/dsc-configure/psdsc.md

  • Line 0, Column 0: [Suggestion: filename-incomplete - See documentation] The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Deleted File(s) This PR deletes Markdown or YAML files owned by another author, or json file(s). The pull request must contain a comment from the pull request author confirming that all the file deletions are intentional before the pull request can be merged.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 64a7f6d:

💡 Validation status: suggestions

File Status Preview URL Details
hub/powertoys/dsc-configure/microsoft-dsc.md 💡Suggestion Details
hub/powertoys/dsc-configure/psdsc.md 💡Suggestion Details
hub/dev-environment/toc.yml ✅Succeeded
hub/powertoys/dsc-configure.md ✅Succeeded n/a (file deleted or renamed)
hub/powertoys/dsc-configure/overview.md ✅Succeeded
hub/powertoys/install.md ✅Succeeded

hub/powertoys/dsc-configure/microsoft-dsc.md

  • Line 0, Column 0: [Suggestion: filename-incomplete - See documentation] The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

hub/powertoys/dsc-configure/psdsc.md

  • Line 0, Column 0: [Suggestion: filename-incomplete - See documentation] The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Deleted File(s) This PR deletes Markdown or YAML files owned by another author, or json file(s). The pull request must contain a comment from the pull request author confirming that all the file deletions are intentional before the pull request can be merged.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

@alvinashcraft
Copy link
Contributor

@Gijsreyn I made the changes to remove the line breaks and approved the PR. Let me know if there's anything else you think should be updated before I merge. It looks good to me. Thanks!

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 13cba53:

💡 Validation status: suggestions

File Status Preview URL Details
hub/powertoys/dsc-configure/microsoft-dsc.md 💡Suggestion Details
hub/powertoys/dsc-configure/psdsc.md 💡Suggestion Details
hub/dev-environment/toc.yml ✅Succeeded
hub/powertoys/dsc-configure.md ✅Succeeded n/a (file deleted or renamed)
hub/powertoys/dsc-configure/overview.md ✅Succeeded
hub/powertoys/install.md ✅Succeeded

hub/powertoys/dsc-configure/microsoft-dsc.md

  • Line 0, Column 0: [Suggestion: filename-incomplete - See documentation] The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

hub/powertoys/dsc-configure/psdsc.md

  • Line 0, Column 0: [Suggestion: filename-incomplete - See documentation] The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Deleted File(s) This PR deletes Markdown or YAML files owned by another author, or json file(s). The pull request must contain a comment from the pull request author confirming that all the file deletions are intentional before the pull request can be merged.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

@Gijsreyn
Copy link
Contributor Author

@Gijsreyn I made the changes to remove the line breaks and approved the PR. Let me know if there's anything else you think should be updated before I merge. It looks good to me. Thanks!

@alvinashcraft - oh wow, much appreciated that you already fixed the line breaks! For me it looks good and can be merged. I'll poke around to get this pull request merged, so users are correctly reverred to the slightly different property names in Microsoft DSC.

Again, thanks for the review Alvin :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants