-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add improved DSC configuration #5707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: docs
Are you sure you want to change the base?
Conversation
|
@Gijsreyn : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 62bc94c:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| hub/powertoys/dsc-configure/microsoft-dsc.md | Details | ||
| hub/powertoys/dsc-configure/psdsc.md | Details | ||
| hub/powertoys/dsc-configure/overview.md | 💡Suggestion | Details |
hub/powertoys/dsc-configure/microsoft-dsc.md
- Line 356, Column 1: [Warning: file-not-found - See documentation]
Invalid file link: '../../../dsc/overview.md'. - Line 408, Column 3: [Warning: file-not-found - See documentation]
Invalid file link: '../../../dsc/overview.md'. - Line 0, Column 0: [Suggestion: filename-incomplete - See documentation]
The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed. - Line 410, Column 3: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/powershell/dsc/overview' will be broken in isolated environments. Replace with a relative link. - Line 411, Column 3: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/windows/package-manager/configuration/' will be broken in isolated environments. Replace with a relative link.
hub/powertoys/dsc-configure/psdsc.md
- Line 631, Column 3: [Warning: file-not-found - See documentation]
Invalid file link: 'index.md'. - Line 0, Column 0: [Suggestion: filename-incomplete - See documentation]
The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed. - Line 38, Column 16: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/powershell/dsc/overview' will be broken in isolated environments. Replace with a relative link. - Line 634, Column 3: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/windows/package-manager/configuration/' will be broken in isolated environments. Replace with a relative link. - Line 635, Column 3: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/powershell/dsc/overview' will be broken in isolated environments. Replace with a relative link.
hub/powertoys/dsc-configure/overview.md
- Line 120, Column 3: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/windows/package-manager/configuration/' will be broken in isolated environments. Replace with a relative link. - Line 121, Column 3: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/powershell/dsc/overview' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments added to fix the build warnings and suggestions. There's already a dsc-configure.md file in the powertoys folder. Are you planning to remove that or link to these files from there? Also, make sure you add or update any links the mention DSC in the powertoys install.md file. Also, the new files need to be added to the table of contents in the ..\dev-environment\toc.yml file.
|
Thanks for creating this draft PR! I added some comments to address while you're working on it. |
|
Learn Build status updates of commit e2d6e3e: 💡 Validation status: suggestions
hub/powertoys/dsc-configure/microsoft-dsc.md
hub/powertoys/dsc-configure/psdsc.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
PRMerger Results
|
My intention was to remove this file and refer to the new |
Thanks for the review Alvin! I think I've captured all your feedback (the first round). Mind taking another stab at it and share your thoughts on referencing to the other repo :) |
|
Learn Build status updates of commit 18ec947: 💡 Validation status: suggestions
hub/powertoys/dsc-configure/microsoft-dsc.md
hub/powertoys/dsc-configure/psdsc.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
PRMerger Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than some formatting (removing extra line breaks), this looks good to me. If there's someone else familiar with DSC who can review it from a technical standpoint, that would be great. Maybe have @niels9001 take a look too, so we're sure the structure fits with his vision of where the PT docs should be going.
|
description provided. And merge it and pull request send code |
|
Learn Build status updates of commit 12933b5: 💡 Validation status: suggestions
hub/powertoys/dsc-configure/microsoft-dsc.md
hub/powertoys/dsc-configure/psdsc.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
PRMerger Results
|
Remove line breaks
|
Learn Build status updates of commit 35f11aa: 💡 Validation status: suggestions
hub/powertoys/dsc-configure/microsoft-dsc.md
hub/powertoys/dsc-configure/psdsc.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
PRMerger Results
|
|
Learn Build status updates of commit 64a7f6d: 💡 Validation status: suggestions
hub/powertoys/dsc-configure/microsoft-dsc.md
hub/powertoys/dsc-configure/psdsc.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
PRMerger Results
|
|
@Gijsreyn I made the changes to remove the line breaks and approved the PR. Let me know if there's anything else you think should be updated before I merge. It looks good to me. Thanks! |
|
Learn Build status updates of commit 13cba53: 💡 Validation status: suggestions
hub/powertoys/dsc-configure/microsoft-dsc.md
hub/powertoys/dsc-configure/psdsc.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
PRMerger Results
|
@alvinashcraft - oh wow, much appreciated that you already fixed the line breaks! For me it looks good and can be merged. I'll poke around to get this pull request merged, so users are correctly reverred to the slightly different property names in Microsoft DSC. Again, thanks for the review Alvin :) |
No description provided.