Add a script for generating portable build #17894
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glyh
commented
Oct 1, 2025
scripts/build-portable.sh
Outdated
|
|
||
| echo "Building Go binaries" | ||
| make libp2p_helper | ||
| local libp2p_binary=${MINA_LIBP2P_HELPER_PATH:-$PWD/src/app/libp2p_helper/result/bin/libp2p_helper} |
There was a problem hiding this comment.
make libp2p_helper will not build anything if this env-var is set, hence we only fall back to the local build when it's not set. This is useful within a nix context.
There was a problem hiding this comment.
^ I guess this should go into documentation. I'll improve it
|
!ci-toolchain-me |
|
^ I want this script to be in our toolchain. |
|
I think with this toolchain we can produce much smaller docker build. I'll do that shortly after I come back. |
glyh
force-pushed
the
lyh/portable-build
branch
3 times, most recently
from
1c1eb93 to
c3d4eca
Compare
glyh
force-pushed
the
lyh/portable-build
branch
8 times, most recently
from
7405837 to
c2106a3
Compare
glyh
commented
Oct 2, 2025
| "ocp-indent.1.7.0" | ||
| "ocp-index.1.3.3" | ||
| "ocplib-endian.1.0" | ||
| "ocplib-endian.1.2" |
There was a problem hiding this comment.
I'm getting compilation error if this is not bumped.
glyh
force-pushed
the
lyh/portable-build
branch
10 times, most recently
from
219c1f2 to
ba6e952
Compare
glyh
force-pushed
the
lyh/portable-build
branch
from
ba6e952 to
8bc1763
Compare
glyh
force-pushed
the
lyh/portable-build
branch
2 times, most recently
from
ff7cd71 to
5698781
Compare
glyh
force-pushed
the
lyh/portable-build
branch
4 times, most recently
from
0a81d3e to
5f1aea0
Compare
lowest supported version, since libc is forward compatible.
glyh
force-pushed
the
lyh/portable-build
branch
5 times, most recently
from
8f1c33e to
f9c4531
Compare
glyh
force-pushed
the
lyh/portable-build
branch
from
f9c4531 to
dcb9901
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script does several things:
/binfolder and setting relative dyn library resolve path/libfolderI've successfully build a bundle on my end under nix, uploaded it to our server and run it bare metal. Hence there should be no compatibility issues.