mina-signer test app #17944
Open
mina-signer test app #17944
+820
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
SanabriaRusso
previously approved these changes
Oct 15, 2025
SanabriaRusso
dismissed
their stale review
Going to get deeper into reviewing this
glyh
requested changes
Oct 15, 2025
There was a problem hiding this comment.
- Could we add a CI job that actually run this test?
Reproducing locally we need to generate a key pair, setting up the service and then run the test with the priv key, I think.
Not sure how a test should get balance in the first place.
- Could we add a
.gitignoreto skip onnode_modules?
dkijania
force-pushed
the
dkijania/mina_signer_test
branch
2 times, most recently
from
e7ab7fe to
3ae35bb
Compare
|
!ci-build-me |
1 similar comment
|
!ci-build-me |
glyh
changed the base branch from
compatible
to
dkijania/extract_runtime_config_builder
Base automatically changed from
dkijania/extract_runtime_config_builder
to
compatible
October 24, 2025 09:05
dkijania
force-pushed
the
dkijania/mina_signer_test
branch
from
cf70a2f to
7166a59
Compare
|
!ci-build-me |
2 similar comments
|
!ci-build-me |
|
!ci-build-me |
dkijania
force-pushed
the
dkijania/mina_signer_test
branch
from
48abb5e to
8dd14d3
Compare
|
!ci-build-me |
dkijania
force-pushed
the
dkijania/mina_signer_test
branch
from
8dd14d3 to
61c7fb9
Compare
dkijania
force-pushed
the
dkijania/mina_signer_test
branch
from
6481e4b to
428c440
Compare
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of automated effort, adding mina-signer test app which sends transaction and validate it is included in the pool. This is part of runbook: https://www.notion.so/o1labs/A16-Validate-build-263e79b1f91081e9a07ed6970a3dbc07. Section Build 1.a.
Example usage of app: