Add an option to control stop time randomness #17964
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --stop-time-interval option sets the upper bound on the number of random hours added to the --stop-time of the daemon. It is optional, with default 9 to match the current daemon behaviour. Setting the option to 0 will disable the randomness entirely. This is useful for ensuring that daemons will stop at deterministic intervals.
|
!ci-build-me |
glyh
approved these changes
Oct 19, 2025
SanabriaRusso
approved these changes
Oct 20, 2025
|
Clean merge is failing. This needs to be ported to develop it seems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --stop-time-interval option sets the upper bound on the number of random hours added to the --stop-time of the daemon. It is optional, with default 9 to match the current daemon behaviour. Setting the option to 0 will disable the randomness entirely. This is useful for ensuring that daemons will stop at deterministic intervals.
I have tested this manually with several different values of the option; notably, the value
0consistently makes the logged wait time 10080 (the default wait time of 168 hours) and the value1causes the wait time to be either 10080 or 10140 (168 or 169 hours).For context, the stop time itself was added in #9387.