Remove empty mixin json to prevent warning #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference map 'seamless-loading-screen-fabric-refmap.json' for seamless_loading_screen-fabric.mixins.json could not be read. If this is a development environment you can ignore this messageThis warning appeared normally when running the game and says to only be ignored when in a development environment.
This is what led to believe your mod was causing an (unrelated) issue I was diagnosing.
However this is only caused by you not having any mixins in the
seamless_loading_screen-fabric.mixins.jsonand doesn't seem to cause any actual problems.This seemed easily fixable, so in order to prevent the warning from confusing others I looked into it and found the cause.
This PR removed the
seamless_loading_screen-fabric.mixins.json. Shouldn't cause any change, but just in case I already built and tested the change.Unless you plan on adding Fabric specific mixins soon, this file can be removed without issue and can be easily reintroduced if needed at a later point.
I hope this doesn't feel petty, I just thought since I had already noticed I might as well submit a PR.