Fix bug where Mac will fail to parse very small floats #941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s represented in scientific-notation.
|
Thanks for the patch. I think we'll have to be a bit careful with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Mac/Windows consistency in parsing very small and large floats represented in scientific-notation.
The original "strtofloatval()" function defined in "lib/lexer.lxx" exhibited different behavior on Windows vs Mac. On Windows (Windows 11, Intel) floating point values such as "4.94065645841247e-324" returned "true". On Mac (Sequoia 15.5, M3 Max) the same floating point value returned "false".
This PR replaces the inconsistent behavior of the original numerical parser "std::istringstream iss(s)" with "std::strtod".