-
Notifications
You must be signed in to change notification settings - Fork 12
Add QK norm to Causal Self Attention Block #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CYHSM
wants to merge
22
commits into
Modalities:main
Choose a base branch
from
CYHSM:qk_norm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,877
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wd_pass.py Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds QK-Norm to self-attention block. Without qk-norm the attention logits are computed as:
(Q @ K^T) / sqrt(d_h), which is equivalent to(||q_i|| * ||k_j|| * cos(θ_ij)) / sqrt(d_h)using the geometric form of the dot product. This means the model can increase distance between logits by either scaling q or k vectors (magnitude) or adjusting the angle between them (direction). QK-Norm constrains the magnitude updates and steers the model towards directional updates (which improves training stability, see this paper for more details)Here are the results for the runs with and without QK-Norm (r2 denotes a second run, s=slow, f=fast, g=gradients, so the first entry will run with around 25 samples/s with torch>2.9.0)
And the loss curves for the extreme LR values:

General Changes
Breaking Changes
Checklist before submitting final PR
python tests/tests.py) - Some still fail, might be due to torch nightly (checking now)CHANGELOG_DEV.md)