[FIX] 예외적인 동작에 대한 방어 #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ait for improved readability and error handling
…unnecessary delays. Cleaned up commented-out code for better readability.
… during asynchronous operations - Introduced a new loading.js file that contains functions to create a loading element and add necessary styles. - Updated showLoading function to utilize the new loading element and styles, enhancing the visual feedback during loading states. - Removed redundant loading element creation code from showLoading for better maintainability.
…ng and code organization - Consolidated WebSocket URL definition for better maintainability. - Refactored online function to streamline token validation and WebSocket connection logic. - Updated showLoading to utilize Promise.all for asynchronous operations, improving readability and performance. - Removed redundant imports and cleaned up code for clarity.
…sary headers - Removed redundant headers from the mail fetch request in the parsePath function. - Streamlined the code for better readability and maintainability.
…outer.js to utilize them - Added `getRequest` and `postRequest` functions in utils.js for streamlined API calls. - Refactored `parsePath` function in router.js to replace direct fetch calls with the new utility functions, improving code readability and maintainability. - Enhanced error handling for API responses in `parsePath` function.
…le logs and timeout - Eliminated console log statements to reduce clutter and improve performance. - Removed the setTimeout delay for removing the loading element, enhancing user experience by immediately hiding the loading indicator after operations complete. - Streamlined the function for better readability and maintainability.
…n successful response => reduce one validate error
- Added a call to change the URL to the home page ("/") after successfully closing all sockets and reloading the page.
- This change improves user navigation by ensuring they are directed to the correct page following an operation.
- Updated the parsePath function to redirect to the "/error" page without using replaceState when an error occurs. - Adjusted the redirection logic for unauthenticated users to maintain the use of replaceState when navigating from non-root paths. - These changes enhance user experience by providing clearer navigation paths during error scenarios.
github-actions
bot
requested review from
cozy-hn,
jaehejun,
seonjo1 and
seungwonme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
주요 구현 사항
리뷰어 참고 사항