Skip to content

refactor: change prediction default 'nbPoints' value to 256k #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hamed-musallam merged 1 commit into from
Jun 16, 2025
Merged

refactor: change prediction default 'nbPoints' value to 256k #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/scripts/nmr-cli/src/prediction/parsePredictionCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const predictionOptions: { [key in keyof GenerateSpectrumOptions]: Options } = {
nbPoints: {
type: 'number',
description: 'Number of points',
default: 1024,
default: 2 ** 18, // 256k points
},
lineWidth: {
type: 'number',
Expand Down Expand Up @@ -146,7 +146,7 @@ async function predictNMR(options: PredictionArgs): Promise<void> {
solvent,
from,
to,
nbPoints = 1024,
nbPoints = 2 ** 18, // 256K
frequency = 400,
lineWidth = 1,
tolerance = 0.001,
Expand Down
Loading