Skip to content

Conversation

@MatthewPyle-NOAA
Copy link
Contributor

@MatthewPyle-NOAA MatthewPyle-NOAA commented Oct 30, 2025

DESCRIPTION OF CHANGES:

  • Changes bad symbolic linking syntax to a cpreq to use the proper workflow.conf files.
  • Corrects some problematic resource request in the spinup save_restart ecf script.
  • Switches parallel copies to only do 10 at a time
  • Increases memory requests in some ecf scripts
  • Fixes .idx file creation issue for new NBMFLD output.

TESTS CONDUCTED:

Machines/Platforms:

  • WCOSS2
    • Cactus/Dogwood
    • Acorn
  • RDHPCS
    • Hera
    • Jet
    • Orion
    • Hercules

Test cases:

  • Engineering tests
    • Non-DA engineering test
    • DA engineering test
      • Retro
      • Ensemble
      • Parallel
  • RRFS fire weather
  • RRFS_A: Based on 20251030 (starting 12Z) testing of new real-time parallel hash.
  • RRFS_B:
  • RTMA:
  • Others:

ISSUE:

CONTRIBUTORS (optional):

@lgannoaa provided the cpreq suggestion for the link script, the ecf memory changes, the parallel copy change. @BenjaminBlake-NOAA provided the UPP script fix.

Changes bad symbolic linking syntax to a cpreq to use the proper
workflow.conf files.

Corrects some problematic resource request in the spinup save_restart
ecf script.
@MatthewPyle-NOAA
Copy link
Contributor Author

Will keep this one open in case there are other changes we want to incorporate into this patch

@BenjaminBlake-NOAA
Copy link
Contributor

@MatthewPyle-NOAA After I confirm my minor fix for adding the NBMFLD idx files is working, let's incorporate that in this PR as well.

@MatthewPyle-NOAA
Copy link
Contributor Author

Sounds good @BenjaminBlake-NOAA

lgannoaa
lgannoaa previously approved these changes Oct 30, 2025
@lgannoaa
Copy link
Contributor

Please include the following fix:
ecf/scripts/ics/firewx/jrrfs_firewx_make_lbcs_master.ecf
scripts/exrrfs_make_lbcs.sh
scripts/exrrfs_post.sh
scripts/exrrfs_analysis_gsi.sh
Thanks

ShunLiu-NOAA
ShunLiu-NOAA previously approved these changes Oct 30, 2025
@BenjaminBlake-NOAA
Copy link
Contributor

I apologize but the fix I added for exrrfs_post.sh wasn't working. I think it is fixed now but I need to confirm that the idx files start being created.

@MatthewPyle-NOAA
Copy link
Contributor Author

Okay, let me know when you're confident that it works.

@BenjaminBlake-NOAA
Copy link
Contributor

It's working now - thanks! It's at the same location on Dogwood

ShunLiu-NOAA
ShunLiu-NOAA previously approved these changes Oct 31, 2025
implications of this shift with Jacob, so sit tight on it for now.
@lgannoaa
Copy link
Contributor

lgannoaa commented Nov 4, 2025

Please note, going forward the modulefiles/tasks/wcoss2 location will NOT be used to run jobs. Module load is happened in ecflow level from $HOMErrfs/ecf/scripts/*.ecf files.

@MatthewPyle-NOAA
Copy link
Contributor Author

@lgannoaa Thanks for the reminder - keep forgetting that detail.

Copy link
Contributor Author

@MatthewPyle-NOAA MatthewPyle-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One item to clean up

@lgannoaa
Copy link
Contributor

lgannoaa commented Nov 5, 2025

At this time, there are still job card change pending on module/library to be tested. We need someone to work on:

  1. Testing new module using cycled parallel to ensure all jobs running as intended.
  2. Remove unused module from run time module loading in each job.
    The ecflow workflow will be updated with the final job card when the above step is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants