Skip to content

Conversation

Tom-Zheng
Copy link
Collaborator

[feat] Support NVFP4 KV Cache

Description

Supports NVFP4 KV Cache.

Test Coverage

accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_fp8[kv_cache_dtype=nvfp4-attn_backend=TRTLLM-torch_compile=False]
accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_fp8[kv_cache_dtype=nvfp4-attn_backend=TRTLLM-torch_compile=True]

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@Tom-Zheng Tom-Zheng requested review from a team as code owners June 11, 2025 14:18
@Tom-Zheng
Copy link
Collaborator Author

/bot run

2 similar comments
@Tom-Zheng
Copy link
Collaborator Author

/bot run

@lucifer1004
Copy link
Collaborator

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8507 [ run ] triggered by Bot

@juney-nvidia
Copy link
Collaborator

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8509 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8507 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8509 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6168 completed with status: 'FAILURE'

@Tom-Zheng
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8575 [ run ] triggered by Bot

Signed-off-by: Tian Zheng <[email protected]>
@Tom-Zheng Tom-Zheng force-pushed the support-nvfp4-kv-cache branch from 8b51fd2 to f173cdf Compare June 12, 2025 08:40
@Tom-Zheng
Copy link
Collaborator Author

/bot kill

@Tom-Zheng
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8643 [ kill ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8644 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8643 [ kill ] completed with state ABORTED

@Tom-Zheng
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8674 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8674 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6290 completed with status: 'FAILURE'

@Tom-Zheng
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8755 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8755 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6356 completed with status: 'FAILURE'

@Tom-Zheng Tom-Zheng marked this pull request as draft June 17, 2025 02:26
@nvzhihanj
Copy link
Collaborator

@Tom-Zheng is it possible to get a rebase of this MR on the top of main? MLPerf team and Shengliang would like to test this MR and see if we can get passing accuracy with nvfp4. It could potentially benefit 405B on GB200/300 in disagg case.
cc: @kaiyux as well.

@Tom-Zheng
Copy link
Collaborator Author

@Tom-Zheng is it possible to get a rebase of this MR on the top of main? MLPerf team and Shengliang would like to test this MR and see if we can get passing accuracy with nvfp4. It could potentially benefit 405B on GB200/300 in disagg case. cc: @kaiyux as well.

Sure, working on it.

@Tom-Zheng Tom-Zheng closed this Aug 4, 2025
@Tom-Zheng
Copy link
Collaborator Author

Rebased PR: #6244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants