Improve TransferAgentTest.SyncMessage #6250

bo-nv · 2025-07-22T07:36:15Z

It's expected that the request is completed when agent gets notified sync messages.

Summary by CodeRabbit

Tests
- Simplified sync message handling in transfer agent tests for improved clarity and efficiency.

coderabbitai · 2025-07-22T07:36:21Z

Walkthrough

The SyncMessage test case in the transfer agent unit tests was refactored. The maximum query constant was moved to the top of the function, and sync message notification logic was streamlined by passing the sync message directly into the TransferRequest constructor. Redundant explicit notification calls and blocking waits were removed, replaced by polling and completion checks.

Changes

File(s)	Change Summary
cpp/tests/unit_tests/executor/transferAgentTest.cpp	Refactored `SyncMessage` test: moved constant, embedded sync message in `TransferRequest`, removed explicit notify calls and blocking waits, updated polling loops.

Estimated code review effort

1 (~3 minutes)

Poem

In the warren where tests align,
Sync messages now flow just fine.
No more loops that spin and wait,
The message rides with transfer’s fate.
Rabbits cheer this tidy quest—
Simpler code, and passing tests! 🐇✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a811f7 and 1b1b187.

📒 Files selected for processing (1)

cpp/tests/unit_tests/executor/transferAgentTest.cpp (5 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

cpp/tests/unit_tests/executor/transferAgentTest.cpp

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

bo-nv · 2025-07-22T07:37:00Z

/bot run --add-multi-gpu-test

tensorrt-cicd · 2025-07-22T07:42:06Z

PR_Github #12539 [ run ] triggered by Bot

longlee0622 · 2025-07-22T07:46:43Z

cpp/tests/unit_tests/executor/transferAgentTest.cpp

@@ -228,7 +228,7 @@ TEST_F(TransferAgentTest, Connect)

 TEST_F(TransferAgentTest, SyncMessage)
 {
-
+    const size_t MAX_QUERY_TIMES = std::numeric_limits<size_t>::max();


Should this be moved to right before the call site? It's better to be a constexpr std::size_t.

Just updated the line

bo-nv · 2025-07-22T08:44:37Z

/bot run --add-multi-gpu-test

tensorrt-cicd · 2025-07-22T08:50:21Z

PR_Github #12546 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-22T08:50:22Z

PR_Github #12539 [ run ] completed with state ABORTED

longlee0622 · 2025-07-22T09:00:39Z

cpp/tests/unit_tests/executor/transferAgentTest.cpp


-    const size_t MAX_QUERY_TIMES = std::numeric_limits<size_t>::max();
    auto notif = nixlAgent1->getNotifiedSyncMessages();


@chuangz0 Do you think it is worth adding a blocking variant of getNotifiedSyncMessages()? The infinite loop should happen inside this function variant.

tensorrt-cicd · 2025-07-22T12:32:27Z

PR_Github #12546 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9328 completed with status: 'FAILURE'

bo-nv · 2025-07-22T15:11:40Z

/bot run --add-multi-gpu-test

tensorrt-cicd · 2025-07-22T15:17:18Z

PR_Github #12582 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-22T17:15:07Z

PR_Github #12582 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9360 completed with status: 'FAILURE'

bo-nv · 2025-07-23T00:10:35Z

/bot run --add-multi-gpu-test

tensorrt-cicd · 2025-07-23T00:34:13Z

PR_Github #12621 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-23T00:47:31Z

PR_Github #12621 [ run ] completed with state FAILURE

bo-nv · 2025-07-23T00:55:01Z

/bot run --add-multi-gpu-test

tensorrt-cicd · 2025-07-23T01:11:45Z

PR_Github #12627 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-23T01:25:46Z

PR_Github #12627 [ run ] completed with state FAILURE

bo-nv · 2025-07-23T03:04:39Z

/bot run --add-multi-gpu-test

tensorrt-cicd · 2025-07-23T03:09:54Z

PR_Github #12640 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-23T05:06:45Z

PR_Github #12640 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9396 completed with status: 'FAILURE'

bo-nv · 2025-07-23T05:17:18Z

/bot run --add-multi-gpu-test

tensorrt-cicd · 2025-07-23T05:22:27Z

PR_Github #12652 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-23T08:25:31Z

PR_Github #12652 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9405 completed with status: 'FAILURE'

Signed-off-by: Bo Deng <[email protected]>

bo-nv · 2025-07-23T09:14:17Z

PR_Github #12652 [ run ] completed with state SUCCESS /LLM/main/L0_MergeRequest_PR pipeline #9405 completed with status: 'FAILURE'

Not related to the PR, #6287 may fix the timeout issue

bo-nv · 2025-07-23T09:14:26Z

/bot run --add-multi-gpu-test

tensorrt-cicd · 2025-07-23T09:19:27Z

PR_Github #12694 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-23T13:20:09Z

PR_Github #12694 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9443 completed with status: 'FAILURE'

bo-nv requested a review from chuangz0 July 22, 2025 07:36

bo-nv self-assigned this Jul 22, 2025

bo-nv requested a review from Shixiaowei02 July 22, 2025 07:36

chuangz0 approved these changes Jul 22, 2025

View reviewed changes

longlee0622 reviewed Jul 22, 2025

View reviewed changes

Shixiaowei02 approved these changes Jul 22, 2025

View reviewed changes

longlee0622 reviewed Jul 22, 2025

View reviewed changes

longlee0622 approved these changes Jul 22, 2025

View reviewed changes

bo-nv force-pushed the user/bo/improve-test branch from f63f5e7 to 6a811f7 Compare July 23, 2025 05:16

bo-nv added 2 commits July 23, 2025 09:13

Improve TransferAgentTest.SyncMessage

d0ebcc3

Signed-off-by: Bo Deng <[email protected]>

fix

1b1b187

Signed-off-by: Bo Deng <[email protected]>

bo-nv force-pushed the user/bo/improve-test branch from 6a811f7 to 1b1b187 Compare July 23, 2025 09:13


		const size_t MAX_QUERY_TIMES = std::numeric_limits<size_t>::max();
		auto notif = nixlAgent1->getNotifiedSyncMessages();

Improve TransferAgentTest.SyncMessage #6250

Are you sure you want to change the base?

Improve TransferAgentTest.SyncMessage #6250

Conversation

bo-nv commented Jul 22, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

bo-nv commented Jul 22, 2025

Uh oh!

tensorrt-cicd commented Jul 22, 2025

Uh oh!

longlee0622 Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

bo-nv Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

bo-nv commented Jul 22, 2025

Uh oh!

tensorrt-cicd commented Jul 22, 2025

Uh oh!

tensorrt-cicd commented Jul 22, 2025

Uh oh!

longlee0622 Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

tensorrt-cicd commented Jul 22, 2025

Uh oh!

bo-nv commented Jul 22, 2025

Uh oh!

tensorrt-cicd commented Jul 22, 2025

Uh oh!

tensorrt-cicd commented Jul 22, 2025

Uh oh!

bo-nv commented Jul 23, 2025

Uh oh!

tensorrt-cicd commented Jul 23, 2025

Uh oh!

tensorrt-cicd commented Jul 23, 2025

Uh oh!

bo-nv commented Jul 23, 2025

Uh oh!

tensorrt-cicd commented Jul 23, 2025

Uh oh!

tensorrt-cicd commented Jul 23, 2025

Uh oh!

bo-nv commented Jul 23, 2025

Uh oh!

tensorrt-cicd commented Jul 23, 2025

Uh oh!

tensorrt-cicd commented Jul 23, 2025

Uh oh!

bo-nv commented Jul 23, 2025

Uh oh!

tensorrt-cicd commented Jul 23, 2025

Uh oh!

tensorrt-cicd commented Jul 23, 2025

Uh oh!

bo-nv commented Jul 23, 2025

Uh oh!

bo-nv commented Jul 23, 2025

Uh oh!

tensorrt-cicd commented Jul 23, 2025

Uh oh!

tensorrt-cicd commented Jul 23, 2025

Uh oh!

bo-nv commented Jul 22, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 22, 2025 •

edited

Loading