[TRTLLM-7169][infra] Fix Slurm multi-node test showing "Submit Test Results" in the test name #6856
Conversation
📝 WalkthroughWalkthroughReplace a stage-based node-online check with a pre-run online check; only run Slurm tests and docker when node is online; add conditional JUnit upload guarded by downloadSucceed; append NVIDIA_IMEX_CHANNELS to dockerArgs for clusterName "dlcluster"; log and terminate if node not online within 2 hours. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Jenkins
participant CloudManager
participant Docker
participant SlurmRunner
participant Results
Jenkins->>CloudManager: isNodeOnline(nodeName)
alt Node online
Jenkins->>Docker: runInDockerOnNodeMultiStage(dockerArgs)
Docker->>SlurmRunner: executeLLMTestOnSlurm()
SlurmRunner-->>Jenkins: downloadSucceed (true/false)
alt downloadSucceed == true
Jenkins->>Results: junit(...) (publish)
else downloadSucceed == false
Jenkins-->>Results: skip junit
end
else Node not online within 2h
Jenkins->>Jenkins: Log "node does not come online... terminating"
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-Post-Merge-1, RTXPro6000-PyTorch-Post-Merge-1" |
|
PR_Github #15097 [ run ] triggered by Bot |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (2)
jenkins/L0_Test.groovy (2)
130-132: Fix MissingPropertyException: downloadSucceed is out of scope; also tolerate empty JUnit resultsdownloadSucceed is declared inside the stage closure and is not visible here. This will throw MissingPropertyException and block JUnit submission. Also, make JUnit tolerate empty matches.
Apply this diff within the selected range to tolerate empty results:
- if (downloadSucceed) { - junit(testResults: "${stageName}/results*.xml") - } + if (downloadSucceed) { + junit(testResults: "${stageName}/results*.xml", allowEmptyResults: true) + }And make these two small edits outside this range to fix scoping:
Groovy (outside-line-range updates to apply):
- Initialize the flag before the stage:
"""
// before pipeline.stage('Submit Test Results') {
def downloadSucceed = false
"""- Inside the stage, assign instead of re-declare:
"""
// replace: def downloadSucceed = sh(script: downloadResultCmd, returnStatus: true) == 0
downloadSucceed = sh(script: downloadResultCmd, returnStatus: true) == 0
"""
265-274: Fail fast when node never comes online; unify model cache host mount
- Echoing on timeout risks a “green” stage with no tests. Fail the stage to make it visible.
- Replace hard-coded host path with a single variable so we don’t drift across clusters/jobs. Keep the container path as /scratch.trt_llm_data.
Apply this diff in the selected range:
- if (CloudManager.isNodeOnline(nodeName)) { - def dockerArgs = "--gpus ${gpuCount} --cap-add=SYS_ADMIN --ipc=host --security-opt seccomp=unconfined -u root:root -v /home/scratch.trt_llm_data:/scratch.trt_llm_data:ro -v /tmp/ccache:${CCACHE_DIR}:rw -v /tmp/pipcache/http-v2:/root/.cache/pip/http-v2:rw --cap-add syslog" + if (CloudManager.isNodeOnline(nodeName)) { + def dockerArgs = "--gpus ${gpuCount} --cap-add=SYS_ADMIN --ipc=host --security-opt seccomp=unconfined -u root:root " + + "-v ${MODEL_CACHE_HOST_DIR}:/scratch.trt_llm_data:ro " + + "-v /tmp/ccache:${CCACHE_DIR}:rw " + + "-v /tmp/pipcache/http-v2:/root/.cache/pip/http-v2:rw --cap-add syslog" if (partition.clusterName == "dlcluster") { dockerArgs += " -e NVIDIA_IMEX_CHANNELS=0" } slurmRunner = runInDockerOnNodeMultiStage(LLM_DOCKER_IMAGE, nodeName, dockerArgs, false) executeLLMTestOnSlurm(pipeline, platform, testList, config, perfMode, stageName, splitId, splits, skipInstallWheel, cpver, slurmRunner) } else { - echo "The node does not come online in 2 hours, terminating the job" + error "The node did not come online within 2 hours; terminating the job" }Groovy (outside-line-range updates to apply):
- Define a single host-side model cache root near the other globals (right after MODEL_CACHE_DIR):
"""
MODEL_CACHE_HOST_DIR="/home/scratch.trt_llm_data"
"""- Use that variable consistently for other mounts in this file:
- Multinode Slurm (around Line 357):
- Replace: /home/scratch.trt_llm_data:/scratch.trt_llm_data:ro
- With: ${MODEL_CACHE_HOST_DIR}:/scratch.trt_llm_data:ro
- Docker runner in launchTestJobs (around Line 1744):
- Replace: -v /mnt/scratch.trt_llm_data:/scratch.trt_llm_data:ro
- With: -v ${MODEL_CACHE_HOST_DIR}:/scratch.trt_llm_data:ro
Note: The dlcluster-specific NVIDIA_IMEX_CHANNELS addition looks good and remains intact.
🧹 Nitpick comments (1)
jenkins/L0_Test.groovy (1)
258-262: Improve observability while waiting on Slurm nodeAdd progress logs for each retry so timeouts are diagnosable.
def counter = 0 while (!CloudManager.isNodeOnline(nodeName) && counter < 12) { + echo "Waiting for node ${nodeName} to come online (${counter + 1}/12)..." sleep(time: 10, unit: 'MINUTES') // Wait 10 minutes to check status of the node again counter++ }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
jenkins/L0_Test.groovy(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
|
PR_Github #15097 [ run ] completed with state |
ZhanruiSunCh
force-pushed
the
user/zhanruis/0813_fix_slurm_test_name
branch
from
aeaf5c0 to
770425b
Compare
|
/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-Post-Merge-1, RTXPro6000-PyTorch-Post-Merge-1" |
|
PR_Github #17201 [ run ] triggered by Bot |
|
PR_Github #17201 [ run ] completed with state |
ZhanruiSunCh
force-pushed
the
user/zhanruis/0813_fix_slurm_test_name
branch
from
b30d8a6 to
5788935
Compare
ZhanruiSunCh
changed the title
chzblych
changed the title
…ults"/"Checking if the Node is Online" in test name Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
ZhanruiSunCh
force-pushed
the
user/zhanruis/0813_fix_slurm_test_name
branch
from
5788935 to
b8a9fdc
Compare
|
/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-Post-Merge-1, RTXPro6000-PyTorch-Post-Merge-1" |
|
PR_Github #18466 [ run ] triggered by Bot |
|
PR_Github #18466 [ run ] completed with state |
|
/bot skip --comment "Only GB200 failed due to known issue on main branch" |
|
PR_Github #18473 [ skip ] triggered by Bot |
|
PR_Github #18473 [ skip ] completed with state |
The example format:
Description
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.