[None][infra] Waive failed tests for release branch 0818

[EmmaQiaoCh]

Summary by CodeRabbit

• Tests
  • Updated test suite to skip several accuracy and long-context evaluations to improve CI stability.
  • Temporarily disabled a speculative execution unit test to avoid false negatives while issues are investigated.
  • These adjustments affect only internal testing; no changes to runtime behavior or public APIs.
  • Improves reliability of continuous integration without impacting end-user features or performance.

Description

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds five new SKIP entries to tests/integration/test_lists/waives.txt and introduces an unconditional pytest skip decorator for test_eagle3 in tests/unittest/_torch/speculative/test_eagle3.py. No functional code or public API changes.

Changes

Cohort / File(s)	Summary
Integration waivers updates tests/integration/test_lists/waives.txt	Appended 5 SKIP entries for specific accuracy tests with nvbugs references.
Speculative decoding unittest skip tests/unittest/_torch/speculative/test_eagle3.py	Added top-level pytest.skip marker (nvbugs/5461761) above parametrize to skip test_llama_eagle3 unconditionally.

Sequence Diagram(s)

sequenceDiagram
  participant Dev as pytest
  participant Col as Test Collector
  participant T as test_eagle3::test_llama_eagle3

  Dev->>Col: Collect tests
  Col->>T: Evaluate decorators
  T-->>Col: pytest.skip(reason="nvbugs/5461761")
  Col-->>Dev: Report test skipped

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• [None][infra] add eagle3 one model accuracy tests #6264 — Also modifies Eagle3-related tests; directly connected to skipping/parameterizing the same area.
• [None][infra] Waive failed cases on main 08/14 #6902 — Updates waives.txt and includes the same Mistral_Nemo_12B_Base::test_fp8 skip entry.
• [TRTQA-2920][fix] Add failed cases into waives.txt #6719 — Adds SKIP entries to the same waives.txt file.

Suggested labels

Speculative Decoding, CI

Suggested reviewers

• niukuo
• ZhanruiSunCh
• yiqingy0
• chzblych

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[EmmaQiaoCh]

/bot skip --comment "Just waive failed cases"

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

tests/unittest/_torch/speculative/test_eagle3.py (1)

16-16: Optional: Make the skip reason explicitly temporary to ease later re-enablement

Adding a brief “TODO” note to the reason helps avoid stale skips on future maintenance passes.

Apply this minimal diff to clarify intent:

-@pytest.mark.skip(reason="https://nvbugs/5461761")
+@pytest.mark.skip(reason="https://nvbugs/5461761 - TODO: unskip when the bug is resolved")

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 28526fe and 4d32cf4.

📒 Files selected for processing (2)

• tests/integration/test_lists/waives.txt (1 hunks)
• tests/unittest/_torch/speculative/test_eagle3.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.py

📄 CodeRabbit Inference Engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+
Python indentation: 4 spaces, no tabs
Maintain module namespace in imports (from package.subpackage import foo; then use foo.SomeClass())
Python file names use snake_case
Python class names use PascalCase
Python functions/methods and local variables use snake_case; variables starting with a number get k_ prefix (e.g., k_99th_percentile)
Global variables use G_ prefixed UPPER_SNAKE_CASE (e.g., G_MY_GLOBAL)
Constants use UPPER_SNAKE_CASE in Python
Avoid shadowing variables from outer scopes in Python
Initialize all externally visible members of a Python class in init
Prefer docstrings for interfaces used outside a file; comments for local code
Use Google-style docstrings for classes and functions (Sphinx-parsable)
Document attributes/variables inline with short docstrings
Avoid reflection when simple alternatives exist (e.g., prefer explicit parameters over dict(**locals()))
In try/except, catch the narrowest exceptions possible
For duck-typing with try/except, keep try body minimal and put logic in else

Files:

• tests/unittest/_torch/speculative/test_eagle3.py

**/*.{cpp,cxx,cc,cu,h,hpp,hxx,hh,cuh,py}

📄 CodeRabbit Inference Engine (CODING_GUIDELINES.md)

Prepend NVIDIA copyright header (current year) to all source files

Files:

• tests/unittest/_torch/speculative/test_eagle3.py

🧠 Learnings (1)

📚 Learning: 2025-07-28T17:06:08.621Z

Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

• tests/integration/test_lists/waives.txt

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Pre-commit Check

🔇 Additional comments (2)

tests/unittest/_torch/speculative/test_eagle3.py (1)

16-16: LGTM: Unconditionally skipping this test matches the release waiver goal

Placing the skip mark above parametrize ensures all parameter combinations are skipped, which aligns with the PR intent for the release branch.

tests/integration/test_lists/waives.txt (1)

286-290: Waiver entries validated and approved

All five NVBugs waivers are unique and target existing test methods:

• accuracy/test_llm_api_pytorch.py::TestMistralSmall24B::test_auto_dtype
• accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_bfloat16
• accuracy/test_llm_api.py::TestMistral_Nemo_12B_Base::test_fp8
• accuracy/test_cli_flow.py::TestLlama3_8BInstructGradient1048k::test_long_context_ppl
• accuracy/test_llm_api_pytorch.py::TestDeepSeekR1::test_nvfp4_multi_gpus

No duplicates found in tests/integration/test_lists/waives.txt and all classes/methods exist in the codebase. Gate known failures without broad impact.