[None][chore] cherry-pick 6940 #7097
Conversation
📝 WalkthroughWalkthroughAdded hardware, memory, and Hopper (SM) gating to disaggregated accuracy and benchmark tests; removed MMLU step from Qwen3 path; removed three DGX B200 test-list entries and three SKIP waivers. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor CI as CI Runner
participant PT as pytest
participant ACC as Accuracy Tests
participant BEN as Disagg Benchmark
CI->>PT: run integration tests
rect rgba(200,235,255,0.25)
note right of ACC: Accuracy tests — device/memory/Hopper gating
PT->>ACC: TestQwen3_8B::test_nixl_backend
ACC->>ACC: check devices>=2 && Hopper?
alt Not satisfied
ACC-->>PT: skip
else
ACC-->>PT: run GSM8K only
end
PT->>ACC: TestDeepSeekV3Lite::test_nixl_backend
ACC->>ACC: check devices>=2 && mem>=60000 && Hopper?
alt Not satisfied
ACC-->>PT: skip
else
ACC-->>PT: run MMLU + GSM8K
end
end
rect rgba(220,255,220,0.25)
note right of BEN: Benchmark — Hopper-only FP8 gating
PT->>BEN: test_disaggregated_benchmark_on_diff_backends[...-fp8]
BEN->>BEN: if model=DeepSeek-V3-Lite & fp8 and SM!=90
alt SM != 90
BEN-->>PT: skip
else
BEN-->>PT: proceed with configs & run
end
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
/bot run --add-multi-gpu-test |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/integration/defs/accuracy/test_disaggregated_serving.py (1)
1-1: Add SPDX header to comply with licensing guidelinestests/integration/defs/accuracy/test_disaggregated_serving.py
This file is missing the standard SPDX header used elsewhere in the repo. Please prepend:+ # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. + # SPDX-License-Identifier: Apache-2.0 # I want to create accuracy tests for disaggregated serving.
🧹 Nitpick comments (1)
tests/integration/defs/disaggregated/test_disaggregated.py (1)
1274-1276: Hopper-only runtime gate is correct; tighten readability of the conditionThe logic is sound. Minor formatting nit to avoid the awkward line break inside the function call and improve readability.
Apply this diff:
- if "DeepSeek-V3-Lite" in benchmark_model_root and "fp8" in benchmark_model_root and get_sm_version( - ) != 90: + if ("DeepSeek-V3-Lite" in benchmark_model_root + and "fp8" in benchmark_model_root + and get_sm_version() != 90): pytest.skip("The test should only run on Hopper")
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
tests/integration/defs/accuracy/test_disaggregated_serving.py(3 hunks)tests/integration/defs/disaggregated/test_disaggregated.py(2 hunks)tests/integration/test_lists/test-db/l0_dgx_b200.yml(0 hunks)tests/integration/test_lists/waives.txt(0 hunks)
💤 Files with no reviewable changes (2)
- tests/integration/test_lists/test-db/l0_dgx_b200.yml
- tests/integration/test_lists/waives.txt
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py
📄 CodeRabbit Inference Engine (CODING_GUIDELINES.md)
**/*.py: Python code must target Python 3.8+
Python indentation: 4 spaces, no tabs
Maintain module namespace in imports (from package.subpackage import foo; then use foo.SomeClass())
Python file names use snake_case
Python class names use PascalCase
Python functions/methods and local variables use snake_case; variables starting with a number get k_ prefix (e.g., k_99th_percentile)
Global variables use G_ prefixed UPPER_SNAKE_CASE (e.g., G_MY_GLOBAL)
Constants use UPPER_SNAKE_CASE in Python
Avoid shadowing variables from outer scopes in Python
Initialize all externally visible members of a Python class in init
Prefer docstrings for interfaces used outside a file; comments for local code
Use Google-style docstrings for classes and functions (Sphinx-parsable)
Document attributes/variables inline with short docstrings
Avoid reflection when simple alternatives exist (e.g., prefer explicit parameters over dict(**locals()))
In try/except, catch the narrowest exceptions possible
For duck-typing with try/except, keep try body minimal and put logic in else
Files:
tests/integration/defs/disaggregated/test_disaggregated.pytests/integration/defs/accuracy/test_disaggregated_serving.py
**/*.{cpp,cxx,cc,cu,h,hpp,hxx,hh,cuh,py}
📄 CodeRabbit Inference Engine (CODING_GUIDELINES.md)
Prepend NVIDIA copyright header (current year) to all source files
Files:
tests/integration/defs/disaggregated/test_disaggregated.pytests/integration/defs/accuracy/test_disaggregated_serving.py
🧠 Learnings (1)
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
Applied to files:
tests/integration/defs/accuracy/test_disaggregated_serving.py
🔇 Additional comments (4)
tests/integration/defs/disaggregated/test_disaggregated.py (1)
23-24: Import for SM gating looks correctPulling in get_sm_version from defs.conftest is appropriate for targeted runtime gating below.
tests/integration/defs/accuracy/test_disaggregated_serving.py (3)
26-26: Adding skip_no_hopper import aligns with new gating usageImporting skip_no_hopper is consistent with the added decorators below.
593-596: DeepSeek V3 Lite NIXL: appropriate hardware/memory gating; confirm memory threshold unitGating on devices, memory, and Hopper is appropriate. Please confirm skip_less_device_memory expects MiB and that 60000 is intentional (vs. 61440 for 60 GiB) to avoid accidental over/under-skipping depending on how the marker computes available memory.
732-734: Qwen3 8B NIXL: Hopper-only + 2-GPU gating LGTMDecorators correctly restrict this test to capable hardware.
|
PR_Github #15932 [ run ] triggered by Bot |
|
PR_Github #15932 [ run ] completed with state |
|
/bot run --add-multi-gpu-test |
1 similar comment
|
/bot run --add-multi-gpu-test |
bo-nv
force-pushed
the
user/bo/main/cherry-pick-6940
branch
from
37e4e8c to
24abb35
Compare
|
/bot run --add-multi-gpu-test |
|
PR_Github #15997 [ run ] triggered by Bot |
|
PR_Github #15997 [ run ] completed with state |
bo-nv
force-pushed
the
user/bo/main/cherry-pick-6940
branch
from
24abb35 to
374a44b
Compare
|
/bot run --add-multi-gpu-test |
|
PR_Github #16097 [ run ] triggered by Bot |
|
PR_Github #16097 [ run ] completed with state |
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #16133 [ run ] triggered by Bot |
bo-nv
force-pushed
the
user/bo/main/cherry-pick-6940
branch
from
374a44b to
c7655f5
Compare
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #16140 [ run ] triggered by Bot |
|
PR_Github #16133 [ run ] completed with state |
|
PR_Github #16140 [ run ] completed with state |
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #16304 [ run ] triggered by Bot |
|
PR_Github #16304 [ run ] completed with state |
Signed-off-by: Bo Deng <[email protected]>
bo-nv
force-pushed
the
user/bo/main/cherry-pick-6940
branch
from
c7655f5 to
6afa77e
Compare
|
/bot skip --comment 'https://nv/trt-llm-cicd/job/main/job/L0_MergeRequest_PR/12258/' |
|
PR_Github #16347 [ skip ] triggered by Bot |
|
PR_Github #16347 [ skip ] completed with state |
Summary by CodeRabbit
Description
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.