[None][ci] move qwen3 tests from b200 to gb200 #7257
Conversation
Signed-off-by: junq <[email protected]>
📝 WalkthroughWalkthroughEnables the GB200-PyTorch-1 entry in the SBSA Slurm Jenkins matrix (now active with splits=1) and updates test lists: removes many Qwen and other PyTorch entries from Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Jenkins as Jenkins Pipeline
participant Matrix as SBSASlurmTestConfigs
participant Scheduler as parallelSlurmJobs
participant Runner as runLLMTestlistOnSlurm
Jenkins->>Matrix: load configs
Note right of Matrix #DDDDFF: GB200-PyTorch-1 enabled -> ["gb200-single","l0_gb200",1,1]
Matrix->>Scheduler: schedule GB200-PyTorch-1
Scheduler->>Runner: runLLMTestlistOnSlurm("gb200-single","l0_gb200", splitId=1, splits=1)
Runner-->>Scheduler: dispatch job(s)
Scheduler-->>Jenkins: report statuses
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
/bot run |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
jenkins/L0_Test.groovy (1)
1925-1929: Fix misleading comment and consider making gpuCount explicit
- The “Not used in the pipeline now” comment is misleading: SBSASlurmTestConfigs is consumed when env.targetArch == AARCH64_TRIPLE. Update the comment to reflect actual usage.
- Minor: Explicitly setting gpuCount=1 makes intent future-proof and consistent with other entries that pass GPU count.
Suggested diff:
SBSASlurmTestConfigs = [ - // Not used in the pipeline now - "GB200-PyTorch-1": ["gb200-single", "l0_gb200", 1, 3], + // SBSA Slurm stages; executed when env.targetArch == AARCH64_TRIPLE + "GB200-PyTorch-1": ["gb200-single", "l0_gb200", 1, 3, 1], "GB200-4_GPUs-PyTorch-1": ["gb200-x4", "l0_gb200_multi_gpus", 1, 1, 4], "GB200-4_GPUs-PyTorch-Post-Merge-1": ["gb200-x4", "l0_gb200_multi_gpus", 1, 1, 4], ]
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
jenkins/L0_Test.groovy(1 hunks)tests/integration/test_lists/test-db/l0_b200.yml(0 hunks)tests/integration/test_lists/test-db/l0_gb200.yml(0 hunks)
💤 Files with no reviewable changes (2)
- tests/integration/test_lists/test-db/l0_gb200.yml
- tests/integration/test_lists/test-db/l0_b200.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
jenkins/L0_Test.groovy (1)
1926-1926: LGTM on wiring GB200 single-GPU PyTorch to SBSA Slurm pathStage name, platform key, and test-db context align with runLLMTestlistOnSlurm() signature and mako arg derivation. With the split coverage concern addressed, this looks good.
|
PR_Github #16553 [ run ] triggered by Bot |
Signed-off-by: junq <[email protected]>
|
/bot run --gpu-type "GB200" |
|
PR_Github #16555 [ run ] triggered by Bot |
|
PR_Github #16553 [ run ] completed with state |
QiJune
requested review from
byshiue,
tongyuantongyu,
chzblych and
juney-nvidia
|
/bot skip --comment "GB200 single GPU pipeline passed" |
|
PR_Github #16555 [ run ] completed with state |
Signed-off-by: junq <[email protected]>
|
/bot run |
|
PR_Github #16571 [ run ] triggered by Bot |
|
/bot skip --comment "GB200 single GPU pipeline passed" |
|
PR_Github #16573 [ skip ] triggered by Bot |
|
PR_Github #16571 [ run ] completed with state |
|
PR_Github #16573 [ skip ] completed with state |
Summary by CodeRabbit
Description
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.