[None][fix] Fix a typo in the Slurm CI codes #7485
Conversation
Signed-off-by: Yanchao Lu <[email protected]>
|
/bot run --stage-list "Build-Docker-Images, DGX_B200-8_GPUs-PyTorch-1, DGX_B200-4_GPUs-PyTorch-1, GB200-PyTorch-1, GB200-4_GPUs-PyTorch-1, GB200-8_GPUs-2_Nodes-PyTorch-1" --disable-fail-fast |
📝 WalkthroughWalkthroughReplaces direct shell execution in jenkins/BuildDockerImage.groovy with a retry-wrapped executor. Updates jenkins/L0_Test.groovy GPU argument selection to prefer NV_GPU, then CUDA_VISIBLE_DEVICES, else gpuCount. Renames dockerGpuOption to dockerGPUOption. Adjusts multi-node launch script to include shebang, pipefail, and exit status propagation. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Jenkins as Jenkins Pipeline
participant Utils as trtllm_utils
participant Docker as Docker CLI
Note over Jenkins,Utils: BuildDockerImage.groovy
Jenkins->>Utils: llmExecStepWithRetry(script: docker build/push, retries=3, max=7200s)
alt success within retries
Utils->>Docker: sh(script)
Docker-->>Utils: exit 0
Utils-->>Jenkins: success
else failure and retries remaining
Utils->>Docker: sh(script) retry
Docker-->>Utils: non-zero exit
Utils-->>Jenkins: final status after retries
end
sequenceDiagram
autonumber
participant Jenkins as Jenkins L0 Tests
participant SLURM as Slurm Cluster
participant Node as Worker Node
participant Docker as Docker
Note over Jenkins: L0_Test.groovy (Multi-node)
Jenkins->>Jenkins: Select GPU args: NV_GPU > CUDA_VISIBLE_DEVICES > gpuCount
Jenkins->>Node: scp launch_script.sh
Jenkins->>SLURM: srun bash launch_script.sh
SLURM->>Node: Execute script (set -o pipefail)
Node->>Docker: docker run ... --cap-add SYSLOG ${dockerArgs}
Node-->>SLURM: exit ${PIPESTATUS[0]}
SLURM-->>Jenkins: return exit status
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
jenkins/L0_Test.groovy (2)
371-379: Simplify quoting for --gpus device to avoid nested escapesQuotes aren’t needed; device lists (e.g., 0,1) are space-free. This reduces brittle escaping.
Apply:
- if [ -n "\$NV_GPU" ]; then - echo "--gpus '\\"device=\$NV_GPU\\"'" - elif [ -n "\$CUDA_VISIBLE_DEVICES" ]; then - echo "--gpus '\\"device=\$CUDA_VISIBLE_DEVICES\\"'" + if [ -n "\$NV_GPU" ]; then + echo "--gpus device=\$NV_GPU" + elif [ -n "\$CUDA_VISIBLE_DEVICES" ]; then + echo "--gpus device=\$CUDA_VISIBLE_DEVICES"
390-390: Normalize flag style for cap-addElsewhere this line uses “=”. Make this consistent to avoid parsing quirks across environments.
Apply:
- "--cap-add SYSLOG" + "--cap-add=SYSLOG"
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
jenkins/BuildDockerImage.groovy(1 hunks)jenkins/L0_Test.groovy(5 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Filenames compiled into a target must be case-insensitively unique
Files:
jenkins/BuildDockerImage.groovyjenkins/L0_Test.groovy
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (2)
jenkins/L0_Test.groovy (2)
521-541: Nice: propagate exit status and enable pipefailAdding set -o pipefail and exiting with PIPESTATUS preserves srun’s exit code through tee. Good hardening.
351-351: No staledockerGpuOptionreferences remain. Rename todockerGPUOptionis consistent across the file.
|
PR_Github #17381 [ run ] triggered by Bot |
Signed-off-by: Yanchao Lu <[email protected]>
|
/bot run --stage-list "Build-Docker-Images, DGX_B200-8_GPUs-PyTorch-1, DGX_B200-4_GPUs-PyTorch-1, GB200-PyTorch-1, GB200-4_GPUs-PyTorch-1, GB200-8_GPUs-2_Nodes-PyTorch-1" --disable-fail-fast |
Signed-off-by: Yanchao Lu <[email protected]>
|
PR_Github #17381 [ run ] completed with state |
|
/bot run --stage-list "Build-Docker-Images, DGX_B200-8_GPUs-PyTorch-1, DGX_B200-4_GPUs-PyTorch-1, GB200-PyTorch-1, GB200-4_GPUs-PyTorch-1, GB200-8_GPUs-2_Nodes-PyTorch-1" --disable-fail-fast |
|
PR_Github #17387 [ run ] triggered by Bot |
|
PR_Github #17387 [ run ] completed with state |
|
/bot run --stage-list "Build-Docker-Images, DGX_B200-8_GPUs-PyTorch-1, DGX_B200-4_GPUs-PyTorch-1, GB200-PyTorch-1, GB200-4_GPUs-PyTorch-1, GB200-8_GPUs-2_Nodes-PyTorch-1" --disable-fail-fast |
|
PR_Github #17431 [ run ] triggered by Bot |
Signed-off-by: Yanchao Lu <[email protected]>
|
/bot run --stage-list "GB200-PyTorch-1, GB200-4_GPUs-PyTorch-1, GB200-8_GPUs-2_Nodes-PyTorch-1" --disable-fail-fast |
|
PR_Github #17472 [ run ] triggered by Bot |
|
PR_Github #17431 [ run ] completed with state |
|
PR_Github #17472 [ run ] completed with state |
|
/bot run --stage-list "GB200-PyTorch-1, GB200-4_GPUs-PyTorch-1, GB200-8_GPUs-2_Nodes-PyTorch-1" --disable-fail-fast |
|
PR_Github #17500 [ run ] triggered by Bot |
|
PR_Github #17500 [ run ] completed with state |
|
/bot run --stage-list "GB200-PyTorch-1, GB200-4_GPUs-PyTorch-1, GB200-8_GPUs-2_Nodes-PyTorch-1" --disable-fail-fast |
|
PR_Github #17527 [ run ] triggered by Bot |
|
PR_Github #17527 [ run ] completed with state |
|
/bot skip --comment "Partial testing is sufficient" |
|
PR_Github #17630 [ skip ] triggered by Bot |
|
PR_Github #17630 [ skip ] completed with state |
Signed-off-by: Yanchao Lu <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]>
Summary by CodeRabbit
New Features
Bug Fixes
Chores
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.