[https://nvbugs/5569754][fix] trtllm llmapi launch port conflict #8582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superjomn
force-pushed
the
launch-uniq-addr2-rel
branch
from
c7afb75 to
aa01b9d
Compare
|
/bot run |
|
PR_Github #22177 [ run ] triggered by Bot. Commit: |
📝 WalkthroughWalkthroughReplaces TCP port binding logic with Python-based IPC address generation stored in TLLM_SPAWN_PROXY_PROCESS_IPC_ADDR. Restricts address generation to MPI rank 0 (or when MPI rank is absent) with added conditional gating. Removes TCP port scanning loop and address formatting code while maintaining HMAC key creation. Changes
Sequence DiagramsequenceDiagram
participant Process as Launch Process
participant MPI as MPI Rank Check
participant IPC as IPC Generator
participant Proxy as Proxy Process
Process->>MPI: Determine MPI rank
alt MPI Rank 0 or No MPI
MPI->>IPC: Generate unique IPC address
IPC->>IPC: Create HMAC key for IPC
IPC->>Process: Export TLLM_SPAWN_PROXY_PROCESS_IPC_ADDR
Process->>Proxy: Spawn with IPC configuration
else Non-zero MPI Rank
MPI->>Process: Skip address generation
Note over Process: Non-root ranks do not export IPC address
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tensorrt_llm/llmapi/trtllm-llmapi-launch (1)
26-33: Harden IPC endpoint generation; fix naming; drop OpenSSL dependency.
- Current var/function names say “tcp/free_port” but we now use IPC. Rename for clarity.
- Long TMPDIR paths on HPC can exceed Unix domain socket limits (~108 bytes), causing bind failures. Prefer a short, controllable directory (default /tmp) and shorter UUID form.
- Avoid external dependency on openssl; use Python’s secrets.
Apply:
-function export_free_tcp_addr_for_spawn_proxy_process { - # Generate unique IPC address without importing tensorrt_llm to avoid MPI initialization conflicts - local free_port=$(python3 -c "import uuid, tempfile, os; print(f'ipc://{os.path.join(tempfile.gettempdir(), \"rpc_test_\" + str(uuid.uuid4()))}')") - export TLLM_SPAWN_PROXY_PROCESS_IPC_ADDR=$free_port - log_stderr "TLLM_SPAWN_PROXY_PROCESS_IPC_ADDR: $TLLM_SPAWN_PROXY_PROCESS_IPC_ADDR" - - export TLLM_SPAWN_PROXY_PROCESS_IPC_HMAC_KEY=$(openssl rand -hex 32) -} +function export_ipc_addr_for_spawn_proxy_process { + # Generate unique IPC address without importing tensorrt_llm to avoid MPI init conflicts + # Use a short, controllable dir to avoid UNIX socket path length limits. + local ipc_addr + ipc_addr=$(python3 - <<'PY' +import os, uuid +dir = os.environ.get('TLLM_IPC_DIR', '/tmp') +name = 'tllm_rpc_' + uuid.uuid4().hex # shorter than str(uuid4) +print(f'ipc://{os.path.join(dir, name)}') +PY +) + export TLLM_SPAWN_PROXY_PROCESS_IPC_ADDR="$ipc_addr" + log_stderr "TLLM_SPAWN_PROXY_PROCESS_IPC_ADDR: $TLLM_SPAWN_PROXY_PROCESS_IPC_ADDR" + + # Generate HMAC key without external deps + export TLLM_SPAWN_PROXY_PROCESS_IPC_HMAC_KEY="$(python3 -c "import secrets; print(secrets.token_hex(32))")" +}
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tensorrt_llm/llmapi/trtllm-llmapi-launch(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
Signed-off-by: Yan Chunwei <[email protected]>
Superjomn
force-pushed
the
launch-uniq-addr2-rel
branch
from
aa01b9d to
b6e1f5e
Compare
|
/bot run |
|
PR_Github #22190 [ run ] triggered by Bot. Commit: |
|
PR_Github #22177 [ run ] completed with state |
|
PR_Github #22190 [ run ] completed with state |
Superjomn
changed the title
kaiyux
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick from #8497
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.