Skip to content

Conversation

xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Oct 22, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated test skip list configuration.

Note: This release contains no user-visible changes. The update addresses internal test infrastructure only.

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251022_LLM_FUNCTION_TEST_1558 branch from eae62c4 to d75056a Compare October 23, 2025 07:04
@xinhe-nv xinhe-nv changed the title [None][chore] Add failed cases into waives.txt [TRTLLM-8638][fix] Add failed cases into waives.txt Oct 23, 2025
@xinhe-nv xinhe-nv marked this pull request as ready for review October 23, 2025 07:06
@xinhe-nv xinhe-nv enabled auto-merge (squash) October 23, 2025 07:06
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@xinhe-nv xinhe-nv requested a review from jieli-matrix October 23, 2025 07:06
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 23, 2025

📝 Walkthrough

Walkthrough

Added a single SKIP entry to the test waives list for a test_ptp_quickstart_multimodal variant with Qwen2.5-VL-7B model, referencing an associated bug ticket. No executable logic changes; test configuration only.

Changes

Cohort / File(s) Change Summary
Test waivers
tests/integration/test_lists/waives.txt
Added SKIP entry for test_e2e.py::test_ptp_quickstart_multimodal[qwen2.5-vl-7b-instruct-Qwen2-VL-7B-Instruct-image-False] with bug reference

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description is largely incomplete compared to the repository's template. The provided description consists of only one brief sentence ("waive failed cases.") and lacks the required sections including an explanation of the issue and solution in the Description section, Test Coverage information, and the PR Checklist items. While the description is not off-topic, it fails to provide substantive context about the change, why it was necessary, or which tests validate the modification. The author should expand the PR description to include the missing template sections. At minimum, please add a Description section explaining which test cases were failing and why they are being waived, a Test Coverage section identifying relevant tests, and ensure the PR Checklist items are addressed. This will provide reviewers with sufficient context to understand the change's purpose and impact.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The pull request title "[TRTLLM-8638][fix] Add flaky failed cases into waives.txt" accurately describes the main change in the changeset. The PR adds a new test entry to the waives.txt file, which is a test-skipping list, exactly as the title indicates. The title is specific about the action (Add), the destination (waives.txt), and the context (fix for TRTLLM-8638), making it clear to anyone reviewing the git history. The title is concise, avoids vague terms, and directly reflects the primary change in the pull request.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22262 [ run ] triggered by Bot. Commit: d75056a

@xinhe-nv xinhe-nv changed the title [TRTLLM-8638][fix] Add failed cases into waives.txt [TRTLLM-8638][fix] Add flaky failed cases into waives.txt Oct 23, 2025
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251022_LLM_FUNCTION_TEST_1558 branch from d75056a to 35f9325 Compare October 23, 2025 08:09
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22262 [ run ] completed with state SUCCESS. Commit: d75056a
/LLM/main/L0_MergeRequest_PR pipeline #16784 (Partly Tested) completed with status: 'FAILURE'

Signed-off-by: Xin He (SW-GPU) <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251022_LLM_FUNCTION_TEST_1558 branch from 53cf753 to 8468c24 Compare October 23, 2025 14:17
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22302 [ run ] triggered by Bot. Commit: 8468c24

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22302 [ run ] completed with state SUCCESS. Commit: 8468c24
/LLM/main/L0_MergeRequest_PR pipeline #16813 (Partly Tested) completed with status: 'SUCCESS'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants