Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Oct 22, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated test configurations to skip certain test scenarios for improved test management.

@xinhe-nv xinhe-nv marked this pull request as ready for review October 23, 2025 06:03
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251023_LLM_FUNCTION_TEST_1557 branch from 53a3ac7 to 1d57c38 Compare October 23, 2025 06:03
@xinhe-nv xinhe-nv changed the title [None][chore] Add failed cases into waives.txt [TRTLLM-8638][fix] Add failed cases into waives.txt Oct 23, 2025
@xinhe-nv xinhe-nv enabled auto-merge (squash) October 23, 2025 06:05
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 23, 2025

📝 Walkthrough

Walkthrough

This PR adds SKIP entries to the test waives list for multiple accuracy/disaggregated_serving test scenarios involving TestLlama3_1_8BInstruct with various parameter configurations, each marked with corresponding nvbugs references.

Changes

Cohort / File(s) Summary
Test Waive List Updates
tests/integration/test_lists/waives.txt
Added multiple SKIP entries for TestLlama3_1_8BInstruct test scenarios with auto_dtype, ctx_pp_gen_tp_asymmetric, and related configurations under accuracy/disaggregated_serving tests, each associated with nvbugs references.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description provided is severely incomplete and does not follow the required template structure. The author submitted only a single sentence, "waive failed cases," which lacks the mandatory sections outlined in the description template: a detailed Description section explaining the issue and solution, a Test Coverage section listing relevant tests, and a completed PR Checklist. While the PR title and raw summary provide some context about the changes, the description itself is too minimal and generic to meet the repository's standards for thorough documentation.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The pull request title "[None][chore] Add failed cases into waives.txt" is directly and clearly related to the main change in the changeset. The raw summary confirms that the PR adds multiple SKIP entries for failed test cases to the tests/integration/test_lists/waives.txt file. The title accurately summarizes this primary change in a concise, single-sentence format. While the "[None]" prefix is somewhat unconventional, it does not obscure the core message, and a teammate reviewing the history would clearly understand that this PR adds failed test cases to the waives file.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22252 [ run ] triggered by Bot. Commit: 1d57c38

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22252 [ run ] completed with state SUCCESS. Commit: 1d57c38
/LLM/main/L0_MergeRequest_PR pipeline #16776 (Partly Tested) completed with status: 'FAILURE'

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251023_LLM_FUNCTION_TEST_1557 branch from 1d57c38 to 04fe228 Compare October 23, 2025 07:47
@xinhe-nv xinhe-nv requested a review from jieli-matrix October 23, 2025 07:48
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22267 [ run ] triggered by Bot. Commit: 04fe228

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251023_LLM_FUNCTION_TEST_1557 branch 2 times, most recently from e2a20fb to 9cec3f7 Compare October 23, 2025 08:35
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22267 [ run ] completed with state FAILURE. Commit: 04fe228
/LLM/main/L0_MergeRequest_PR pipeline #16789 (Partly Tested) completed with status: 'FAILURE'

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251023_LLM_FUNCTION_TEST_1557 branch from 9cec3f7 to ac5bc74 Compare October 23, 2025 14:16
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22299 [ run ] triggered by Bot. Commit: ac5bc74

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22299 [ run ] completed with state SUCCESS. Commit: ac5bc74
/LLM/main/L0_MergeRequest_PR pipeline #16810 (Partly Tested) completed with status: 'SUCCESS'

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251023_LLM_FUNCTION_TEST_1557 branch from ac5bc74 to d656fe7 Compare October 24, 2025 02:34
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22355 [ reuse-pipeline ] triggered by Bot. Commit: d656fe7

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22355 [ reuse-pipeline ] completed with state SUCCESS. Commit: d656fe7
Reusing PR_Github #22299 (Partly Tested) for commit d656fe7

Signed-off-by: Xin He (SW-GPU) <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251023_LLM_FUNCTION_TEST_1557 branch from d656fe7 to 72257b6 Compare October 24, 2025 03:30
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22367 [ reuse-pipeline ] triggered by Bot. Commit: 72257b6

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22367 [ reuse-pipeline ] completed with state SUCCESS. Commit: 72257b6
Reusing PR_Github #22299 (Partly Tested) for commit 72257b6

@xinhe-nv xinhe-nv merged commit 59375e8 into NVIDIA:main Oct 24, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20251023_LLM_FUNCTION_TEST_1557 branch October 24, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants