Skip to content

Conversation

lucaslie
Copy link
Member

@lucaslie lucaslie commented Oct 22, 2025

Summary by CodeRabbit

  • Chores
    • Reorganized custom operations module structure by consolidating import references under a unified namespace for improved code organization.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@lucaslie lucaslie requested a review from a team as a code owner October 22, 2025 19:55
@lucaslie lucaslie requested a review from nvchenghaoz October 22, 2025 19:55
@lucaslie lucaslie changed the title [AutoDeploy[ correct import for mxfp4_moe unit test [AutoDeploy] correct import for mxfp4_moe unit test Oct 22, 2025
@lucaslie lucaslie changed the title [AutoDeploy] correct import for mxfp4_moe unit test [https://nvbugs/5604136][fix] AutoDeploy: correct import for mxfp4_moe unit test Oct 22, 2025
@lucaslie
Copy link
Member Author

/bot run

@lucaslie lucaslie requested a review from Fridah-nv October 22, 2025 19:57
@lucaslie lucaslie moved this from Backlog to In review in AutoDeploy Board Oct 22, 2025
@lucaslie lucaslie requested a review from brb-nv October 22, 2025 19:58
@lucaslie lucaslie self-assigned this Oct 22, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 22, 2025

📝 Walkthrough

Walkthrough

Import path for IS_TRITON_KERNELS_AVAILABLE updated from tensorrt_llm._torch.auto_deploy.custom_ops.mxfp4_moe to tensorrt_llm._torch.auto_deploy.custom_ops.fused_moe.mxfp4_moe, reflecting module reorganization where mxfp4_moe was moved to a fused_moe subpackage.

Changes

Cohort / File(s) Summary
Import path update
tests/unittest/_torch/auto_deploy/unit/multigpu/custom_ops/test_mxfp4_moe_ep.py
Updated import statement for IS_TRITON_KERNELS_AVAILABLE to reference new module location in fused_moe subpackage

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description is largely incomplete. While the template structure is present, all critical sections are empty: the Description section contains no explanation of the issue or solution, Test Coverage is blank, and the PR Checklist items remain mostly unchecked. The description includes only the template boilerplate and GitHub Bot help documentation without any substantive content about the changes being made. Fill in the required sections of the PR description: add a Description explaining why the import path needed to be corrected and what the fix accomplishes, list the relevant tests that cover this change in the Test Coverage section, and ensure the PR Checklist items are properly reviewed and marked as appropriate. Following the template format specified in the repository (e.g., "[None][fix] Summary") would also improve consistency.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[AutoDeploy] correct import for mxfp4_moe unit test" clearly and specifically describes the main change in the pull request—correcting an import path for IS_TRITON_KERNELS_AVAILABLE in a unit test file. The title is concise, avoids vague terms, and directly communicates the primary change to someone reviewing the repository history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between df689f8 and b675eb6.

📒 Files selected for processing (1)
  • tests/unittest/_torch/auto_deploy/unit/multigpu/custom_ops/test_mxfp4_moe_ep.py (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

  • tests/unittest/_torch/auto_deploy/unit/multigpu/custom_ops/test_mxfp4_moe_ep.py
**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

  • tests/unittest/_torch/auto_deploy/unit/multigpu/custom_ops/test_mxfp4_moe_ep.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

  • tests/unittest/_torch/auto_deploy/unit/multigpu/custom_ops/test_mxfp4_moe_ep.py
🧬 Code graph analysis (1)
tests/unittest/_torch/auto_deploy/unit/multigpu/custom_ops/test_mxfp4_moe_ep.py (1)
tensorrt_llm/_torch/custom_ops/torch_custom_ops.py (1)
  • fused_moe (125-245)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/unittest/_torch/auto_deploy/unit/multigpu/custom_ops/test_mxfp4_moe_ep.py (1)

8-10: Import path update verified as correct.

The symbol IS_TRITON_KERNELS_AVAILABLE exists in the new module location, no other files depend on the old import path, and the import will work correctly. The module reorganization has been properly executed with no breaking changes.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lucaslie lucaslie requested review from achartier and hchings October 22, 2025 19:58
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22208 [ run ] triggered by Bot. Commit: b675eb6

Signed-off-by: Lucas Liebenwein <[email protected]>
@lucaslie lucaslie force-pushed the ll/fix_mxfp4_moe_test branch from b675eb6 to adfebfd Compare October 22, 2025 20:21
@lucaslie
Copy link
Member Author

/bot run

@lucaslie lucaslie enabled auto-merge (squash) October 22, 2025 20:26
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22209 [ run ] triggered by Bot. Commit: adfebfd

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22208 [ run ] completed with state ABORTED. Commit: b675eb6
LLM/main/L0_MergeRequest_PR #16745 (Blue Ocean) completed with status: ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22209 [ run ] completed with state SUCCESS. Commit: adfebfd
/LLM/main/L0_MergeRequest_PR pipeline #16746 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@lucaslie lucaslie merged commit 77fa5df into NVIDIA:main Oct 23, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in AutoDeploy Board Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants