Fix: when_all cancelled from environment #1718
Open
+54
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case when when_all is being stopped from a stop source in the environment, the stop_source was triggered multiple times leading to a use after free bug. This patch fixes this by performing the following steps: - Inside the stop callback, increment the reference count. - Try setting the state to stopped, only if stopped, trigger the internal stop_source which cancels the children. - Arrive to decrement the count again and handle any concurrent completions if needed.
Collaborator
|
/ok to test 1982e32 |
ericniebler
reviewed
Dec 17, 2025
Collaborator
|
/ok to test 75c45fb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case when when_all is being stopped from a stop source in the environment, the stop_source was triggered multiple times leading to a use after free bug.
This patch fixes this by performing the following steps: