Skip to content

Enhancement/add configurable webpreferences to menubar #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enhancement/add configurable webpreferences to menubar #694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9f08bd
add configurable webpreferences
gwleuverink Sep 10, 2025
60dc3c6
add webPreferences phpdoc
gwleuverink Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Facades/MenuBar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* @method static void icon(string $icon)
* @method static void resize(int $width, int $height)
* @method static void contextMenu(Menu $contextMenu)
* @method static void webPreferences(array $preferences)
*/
class MenuBar extends Facade
{
Expand Down
1 change: 1 addition & 0 deletions src/Facades/Window.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
* @method static void preventLeaveDomain(bool $preventLeaveDomain = true)
* @method static void preventLeavePage(bool $preventLeavePage = true): self
* @method static void suppressNewWindows()
* @method static void webPreferences(array $preferences)
*/
class Window extends Facade
{
Expand Down
10 changes: 10 additions & 0 deletions src/MenuBar/MenuBar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ class MenuBar

protected bool $showOnAllWorkspaces = false;

protected array $webPreferences = [];

protected Client $client;

public function __construct()
Expand Down Expand Up @@ -111,6 +113,13 @@ public function withContextMenu(Menu $menu): self
return $this;
}

public function webPreferences(array $preferences): static
{
$this->webPreferences = $preferences;

return $this;
}

public function toArray(): array
{
return [
Expand All @@ -132,6 +141,7 @@ public function toArray(): array
'contextMenu' => ! is_null($this->contextMenu) ? $this->contextMenu->toArray()['submenu'] : null,
'alwaysOnTop' => $this->alwaysOnTop,
'showOnAllWorkspaces' => $this->showOnAllWorkspaces,
'webPreferences' => $this->webPreferences,
];
}
}
Loading