Skip to content

Added Selective Parsing of Attributes by Tag Name #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added Selective Parsing of Attributes by Tag Name #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/xmlparser/OptionsBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const defaultOptions = {
//ignoreRootElement : false,
parseTagValue: true,
parseAttributeValue: false,
attributeTargetTags: [], // Optional Array of Tag Names that will have attributes parsed
trimValues: true, //Trim string values of tag and attributes
cdataPropName: false,
numberParseOptions: {
Expand Down
4 changes: 2 additions & 2 deletions src/xmlparser/OrderedObjParser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,10 @@ function resolveNameSpace(tagname) {
const attrsRegx = new RegExp('([^\\s=]+)\\s*(=\\s*([\'"])([\\s\\S]*?)\\3)?', 'gm');

function buildAttributesMap(attrStr, jPath) {
if (!this.options.ignoreAttributes && typeof attrStr === 'string') {
const tagName = jPath.split('.').pop();
if (!this.options.ignoreAttributes && typeof attrStr === 'string' && (!this.options.attributeTargetTags.length || this.options.attributeTargetTags.includes(tagName))) {
// attrStr = attrStr.replace(/\r?\n/g, ' ');
//attrStr = attrStr || attrStr.trim();

const matches = util.getAllMatches(attrStr, attrsRegx);
const len = matches.length; //don't make it inline
const attrs = {};
Expand Down