Bugfix: Multiselectvalues where not updated #97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this element with the "multiple" option, the value was not updated when it was changed from outside.
This was because "ngOnChanges" only performes a value checking not, a deep value checking. (Source: https://stackoverflow.com/questions/34796901/angular2-change-detection-ngonchanges-not-firing-for-nested-object ).
Beucause with the "multiple" option, "value" is a "string[]", a simple "ngOnChanges" check is not enough enough, it needs to check on "ngDoCheck".
Code:
This code only check, if the value is an array and sets the new value in an array. To detect the change,
private oldValueLength = 0;
Is added, to keep track of the last lenght. (changes from null to array where already detected.)