Skip to content

Remove generic is_power and root methods #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove generic is_power and root methods #1479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions src/generic/Misc/Rings.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,3 @@
###############################################################################
#
# Power testing and root
#
###############################################################################

function is_power(a::RingElem, n::Int)
if isone(a) || iszero(a)
return true, a
end
if isone(-a) && isodd(n)
return true, a
end
R = parent(a)
Rt = PolyRing(R)
x = gen(Rt)
r = roots(x^n - a)
if length(r) == 0
return false, a
else
return true, r[1]
end
end

function root(a::RingElem, n::Int)
fl, b = is_power(a, n)
fl || error("element does not have a $n-th root")
return b
end

@doc raw"""
rising_factorial(x::RingElement, n::Integer)

Expand Down