Skip to content

Conversation

fingolfin
Copy link
Member

This is also in PR #2051 (where we discovered the issue) but as that seems stalled let's apply this fix right now.

@fingolfin fingolfin added bug Something isn't working release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels May 1, 2025
Copy link

codecov bot commented May 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.37%. Comparing base (c5edd01) to head (6c45392).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/julia/Matrix.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2065   +/-   ##
=======================================
  Coverage   88.37%   88.37%           
=======================================
  Files         125      125           
  Lines       31585    31585           
=======================================
  Hits        27912    27912           
  Misses       3673     3673           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@joschmitt joschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not great that this is not tested, but #2050 should take care of that at some point...

@joschmitt joschmitt merged commit 9e2da0e into master May 1, 2025
29 of 30 checks passed
@joschmitt joschmitt deleted the mh/fix-swap_cols branch May 1, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants