Extend click types #2685
Open
Extend click types #2685
+69
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mt-ob
reviewed
Nov 21, 2025
| click_to_python_types = get_click_to_python_types() | ||
|
|
||
| # Define a recursive type alias for JSON | ||
| JSON = Union[Dict[str, "JSON"], List["JSON"], str, int, float, bool, None] |
Collaborator
There was a problem hiding this comment.
nit: you can import this also from metaflow/metaflow_config.py??
right now it is defined at two places...
mt-ob
approved these changes
Nov 21, 2025
Collaborator
mt-ob
left a comment
mt-ob
left a comment
There was a problem hiding this comment.
LGTM, but one minor comment...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to allow extensions to be able to add their own custom parameter types, and to be able to use these custom parameters via the Runner API as well. This PR allows extensions to update the list of "approved" parameter types in the metaflow runner API.
It follows logic similar to
get_pinned_conda_libsfunction.