Skip to content

end simulation correction when simulation has callbacks #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

end simulation correction when simulation has callbacks #815

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae7fe62
end simulation correction when simulation has callbacks
rnwatanabe Mar 14, 2025
9c80a88
end simulation correction when simulation has callbacks
rnwatanabe Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyNN/common/control.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def run_until(time_point, callbacks=None):
if callbacks:
callback_events = [(callback(simulator.state.t), callback)
for callback in callbacks]
while simulator.state.t + 1e-9 < time_point:
while simulator.state.t + 1e-9 < time_point - simulator.state.dt:
callback_events.sort(key=lambda cbe: cbe[0], reverse=True)
next, callback = callback_events.pop()
# collapse multiple events that happen within the same timestep
Expand Down