Skip to content

Conversation

@JuliaSprenger
Copy link
Member

This is an alternative implementation to #944 that introduced neuraview file header interpretation and a corresponding first simple unit test. @fccaa Can you confirm this version is working for your files?

@pep8speaks
Copy link

pep8speaks commented Jun 29, 2021

Hello @JuliaSprenger! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-29 12:38:52 UTC

@fccaa
Copy link

fccaa commented Jul 1, 2021

This is an alternative implementation to #944 that introduced neuraview file header interpretation and a corresponding first simple unit test. @fccaa Can you confirm this version is working for your files?

Hi. The version here behaves the same as #944 . I have no error message to open my files. I think this version is working.

@JuliaSprenger
Copy link
Member Author

@fccaa Thanks for checking. I would prefer to have the new header format properly embedded in the existing header routines. I hope you don't mind my alternative implementation. Thanks again for pointing this out and taking the initiative.
@samuelgarcia Ready for review from your side.

@samuelgarcia samuelgarcia added this to the 0.10.0 milestone Jul 1, 2021
@samuelgarcia
Copy link
Contributor

OK for me.

@samuelgarcia samuelgarcia merged commit ca35743 into NeuralEnsemble:master Jul 1, 2021
@JuliaSprenger JuliaSprenger deleted the add/neuraview branch April 3, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants