Accept file and path names to be pathlib objects #911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return_path=return_path, | ||
| clean=clean) | ||
|
|
||
| def create_file_reader(self, filename=None, return_path=False, |
Contributor
There was a problem hiding this comment.
I don't remember why we add this before.
it is not used anymore ?
Member
Author
There was a problem hiding this comment.
It is not used within Neo and is also not working, e.g. when trying to create a generic reader as the default filename does not exist.
Contributor
|
Ok for me. |
Member
Author
|
I am not sure why circleCI is not receiving output for some time. I think we should investigate this phenomenon in general, since this has been an issue also in other PRs... Maybe it's a matter of adjusting the CI configuration to our current requirements? |
This commits adds a test that is running all IOs with an input filename / directory name specified as a pathlib object.
JuliaSprenger
force-pushed
the
pathlib_filenames
branch
from
d58c08a to
357ed72
Compare
Member
Author
|
This is rebased and tests are fixed. @samuelgarcia ready for final review. |
Contributor
|
OK for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All IOs implicitly assume that the file and directory names provided are strings. Therefore many IOs fail, when a path specified as a pathlib object is provided instead. This PR introduces the automatic conversion of filenames and directory names, for all IOs and adds a common IO test.