-
Notifications
You must be signed in to change notification settings - Fork 266
Fixes for cheetah v5.4.0 #913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for cheetah v5.4.0 #913
Conversation
Tests for v5.5.1 still failing.
…ssignement. Using a tolerance over a longer experiment is not sensitive enough to detect blocks where perhaps a large amount of samples are dropped and there is a small gap afterwards.
Strange this hasn’t caused issues before with other file sets.
Like files from Dr. Florian Mormann’s lab.
# Conflicts: # neo/rawio/neuralynxrawio/__init__.py # neo/rawio/neuralynxrawio/ncssections.py # neo/rawio/neuralynxrawio/nlxheader.py
# Conflicts: # neo/test/rawiotest/test_neuralynxrawio.py
These were created by inadvertendly committed the required changes on another branch and needing to cherry-pick off that branch. # Conflicts: # neo/rawio/neuralynxrawio/__init__.py # neo/rawio/neuralynxrawio/ncssections.py # neo/rawio/neuralynxrawio/nlxheader.py # neo/test/rawiotest/test_neuralynxrawio.py
Attempt to see what is happening with CircleCI testing.
# Conflicts: # neo/rawio/neuralynxrawio/ncssections.py
# Conflicts: # neo/test/iotest/test_neuralynxio.py # neo/test/rawiotest/test_neuralynxrawio.py # Conflicts: # neo/test/iotest/test_neuralynxio.py # neo/test/rawiotest/test_neuralynxrawio.py
…etahV5.4.0 # Conflicts: # neo/rawio/neuralynxrawio/nlxheader.py # neo/test/iotest/test_neuralynxio.py
|
Hello @PeterNSteinmetz! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
|
Two W204 PEP8 warnings to be ignored. |
|
Note that PR # 32 in ephy_testing_data at gin-g.node was replaced by # 35 |
|
Looks like the circleci tests are failing because the test data for Cheetah 5.4.0 is not yet in the gin repository. |
|
This is strange the file is in gin: Note that the old PR you did on gin is not deletable. |
|
Maybe the CircleCI tests need to be restarted again? That looks like the correct file. It is truncated and was committed simply using git, no annexing needed. |
|
Yes, I restarted the test. |
|
These changes seems to pass the tests locally, so I assume it has to do with some problem with integrating the files in gin and CircleCI. Looks like it is now hanging on a timeout somehow? |
This request incorporates changes to handle headers from Cheetah v5.4.0. Also better error recovery and messages when new header styles that are not understood are encountered.
This also handles the type of variability in the time gaps between records in a contiguous section which can arise when the sampling rate is quite low, like 1017 Hz.
This resolves issue #906
This will not pass tests until PR # 32 in ephy_testing_data is incorporated at gin-g.node.