Remove ElphyIO, as it is not currently maintained #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi Andrew. |
Member
Author
|
I don't know how feasible that is. The last person to maintain this was @dguarino, who had plans to rewrite and simplify the entire module, but he is working on other things now. |
Member
|
@samuelgarcia I think we could keep a minimal version of the IO if we would have corresponding tests. There are actually some files on gin, but no io specific unittest based on these. Do you think it would be feasible on adding some tests, i.e. do you know another tool that reads elphy files so we can compare the resulting traces? |
Merged
Member
|
closed via #1011 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.