-
Notifications
You must be signed in to change notification settings - Fork 266
Axonarawio add pos stream #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Axonarawio add pos stream #980
Conversation
|
Hello @sbuergers! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-04-26 12:42:06 UTC |
|
Hi Steffen, tell us when it is ready to review. |
|
Hi Samuel, I think it's ready for review from my end. I am not sure if I dealt with the sampling frequency of the position data correctly. @JuliaSprenger mentioned that there is a way to incorporate non-stationary sampling frequencies, but I wasn't quite sure how. Currently I am simply assuming a fixed rate of 100Hz (which ideally is true, but empirically, at least in our sample data, is only approximately true, because there is a period during the experiment where it starts fluctuating for a while). One of the Tests pass locally. Interestingly my local linter (flake8) found a Pep8 issue that pep8speaks missed (>79 char line length). |
|
Julia pointed me toward how to deal with irregularly sampled signals. So converting to draft for now and trying to make appropriate changes. |
|
Looking at the basefromrawio it does not seem like IrregularySampledSignals are supported on that level yet. @samuelgarcia Do you think it makes sense to find a workaround now to include these for the AxonaIO or do you want to unify AnalogSignals and IrregularlySampledSignals first? |
|
For the moment we implemented reading the position data in nwb-converion-tools, but once we figure out how to incorporate irregularly sampled signals it shouldn't be too hard to finalize this also for neo! |
|
Including pos data in the AxonaRawIO will be postponed until IrregularlySampledSignals are supported on the RawIO level. Until then I close this PR. Feel free to reopen to continue working on this. |
In addition to ecephys data the Axona system saves video tracking data in the
.binfiles containing the raw data.Each data packet contains a header, footer and 3 samples of ecephys data for each channel. The header includes a
flag, either ADU1 or ADU2, where ADU2 denotes that video tracking data is available in this packet, which is then located
in the header.
To quote from the file format manual:
In this PR this video tracking position (pos) data is added to
axonarawio.pyas a separate stream.