Skip to content

Improve compute_pvals_perm function #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Improve compute_pvals_perm function #818

wants to merge 2 commits into from

Conversation

qbarthelemy
Copy link
Contributor

This PR replaces

        perm = rng.randint(2, size=(data.shape[0],))
        perm[perm == 0] = -1

by

        perm = rng.choice([1, -1], size=(data.shape[0],), replace=True)

and renames "exhaustive test" by "exact test".

@qbarthelemy qbarthelemy changed the title Improve code for compute_pvals_perm Improve compute_pvals_perm function Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@qbarthelemy