Deprecate hacky way of making structured attrs #13273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
with-tests
Ericson2314
force-pushed
the
deprecate-structured-attrs-hack
branch
from
a4713ed to
a42e1a2
Compare
Mic92
reviewed
May 27, 2025
edolstra
reviewed
May 27, 2025
edolstra
approved these changes
May 27, 2025
Ericson2314
force-pushed
the
deprecate-structured-attrs-hack
branch
from
d1c86c9 to
ddefbdd
Compare
Ericson2314
force-pushed
the
deprecate-structured-attrs-hack
branch
from
ddefbdd to
35d56dd
Compare
The method tested for in the previous commit is now deprecated. Co-authored-by: Eelco Dolstra <[email protected]>
Ericson2314
force-pushed
the
deprecate-structured-attrs-hack
branch
from
35d56dd to
7577d2d
Compare
roberth
added
the
backports rejected
dasJ
reviewed
Aug 12, 2025
| @@ -0,0 +1,11 @@ | |||
| --- | |||
| synopsis: Deprecate manually making structured attrs with `__json = ...;` | |||
| prs: [13220] | |||
There was a problem hiding this comment.
This is the wrong PR and now shows up wrong on Discourse ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The first commit adds a test for a trick with
builtins.derivationthat currently works today.The second commit adds a deprecation message for that trick, and extends the test to check for the deprecation message.
Context
Thanks to @puckipedia for telling me about this, while we went over #13263.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.