Skip to content

Conversation

h0nIg
Copy link
Contributor

@h0nIg h0nIg commented Jun 5, 2025

Motivation

we build a docker image with nix.
docker.nix is complex + without docu references and docker.nix looks like a template rather than a reuse function. General functionality which do not need a refactoring should get moved to nixpkgs, in order to avoid code duplication.

Context

https://discourse.nixos.org/t/how-to-build-a-docker-image-with-a-working-nix-inside-it/32960

I looked at the source code and expected to find maybe 200 lines to bootstrap Nix but instead I found almost 800 lines and too many things happening for how seemingly simple the end goal is.

@h0nIg h0nIg requested a review from edolstra as a code owner June 5, 2025 21:33
@edolstra edolstra merged commit 99c20e6 into NixOS:master Jul 7, 2025
12 checks passed
@basbebe
Copy link

basbebe commented Jul 9, 2025

nixConf is now unused.
It was a handy way to edit nix.conf for custom images.

How is this supposed to work now?

@h0nIg
Copy link
Contributor Author

h0nIg commented Jul 9, 2025

@basbebe shit, during the last merge commit i may have missed this, #13435

@h0nIg h0nIg mentioned this pull request Jul 9, 2025
@basbebe
Copy link

basbebe commented Jul 9, 2025

That was quick, thanks!

@roberth roberth added backports created Does not require attention and can be filtered away backport 2.28-maintenance Automatically creates a PR against the branch backport 2.29-maintenance Automatically creates a PR against the branch labels Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.28-maintenance Automatically creates a PR against the branch backport 2.29-maintenance Automatically creates a PR against the branch backports created Does not require attention and can be filtered away
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants