Implement treefmt's stdin spec #358
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfly
commented
Nov 13, 2025
| toTargets Nixfmt{files = [], filename} = pure [stdioTarget filename] | ||
| toTargets Nixfmt{files = ["-"], filename} = pure [stdioTarget filename] | ||
| toTargets Nixfmt{files = [], stdin_filepath = Just filepath} = pure [stdioTarget filepath] | ||
| toTargets Nixfmt{files = _ : _, stdin_filepath = Just _} = error "Cannot specify both positional files and --stdin-filepath" |
Collaborator
Author
There was a problem hiding this comment.
This seems wrong to me. Should I instead change the return type of toTargets? Pointers appreciated.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/formatting-team-meeting-2025-11-11/72019/4 |
This completes #305
jfly
commented
Nov 25, 2025
Collaborator
Author
jfly
left a comment
jfly
left a comment
There was a problem hiding this comment.
Discussed in today's team meeting. Let's preserve the old behavior (with deprecation warnings), and then sit and wait for treefmt to finalize the stdin spec.
| toTargets :: Nixfmt -> IO [Target] | ||
| toTargets Nixfmt{files = [], filename} = pure [stdioTarget filename] | ||
| toTargets Nixfmt{files = ["-"], filename} = pure [stdioTarget filename] | ||
| toTargets Nixfmt{files = [], stdin_filepath = Just filepath} = pure [stdioTarget filepath] |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| toTargets Nixfmt{files = [], stdin_filepath = Just filepath} = pure [stdioTarget filepath] | |
| toTargets Nixfmt{files = [], stdin_filepath = Just filepath} = do | |
| -- add a warning. https://github.com/NixOS/nixfmt/blob/b672593734d64eefb675b1f1de26f8a73fe00c40/main/Main.hs#L130 | |
| pure [stdioTarget filepath] |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/formatting-team-meeting-2025-11-25/72427/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full disclosure: the treefmt stdin spec is not yet finalized (see numtide/treefmt#586). However, nothing prevents us from implementing the version of it that I hope will be approved.
This completes #305.
I have very little haskell knowledge. I'm sure there are issues with this implementation. Be kind, I'm excited to learn more!