This repository was archived by the owner on Jun 28, 2025. It is now read-only.
logo: Provide an easy path to optimized SVGs and exported PNGs #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The non-logo files are not part of the build, as they are files made for specific usage, and should not be part of the NixOS assets for general usage.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The non-logo files are not part of the build, as they are files made for specific usage, and should not be part of the NixOS assets for general usage.
With the added Nix expression, someone that needs PNGs or optimized SVGs can get them more easily than previously, where they'd need to get into inkscape and export the files.
With future clean-up work, this may be enhanced by exporting different layers. This would allow exporting the flat (for print) and gradient based variants.
It's done directly as a Nix expression, as these assets are not intended to be part of an automated pipeline. This for end-user convenience.
@Ericson2314 first of all, sorry for the span of years since your initial contribution.
Can you please remind me the rationale behind #37, #38 and #39?
I'm wondering if part of it will be addressed here. I'm thinking mainly about producing "built assets" versions of the SVG files, which drops all inkscape-isms, and then get optimized.
Though I recall (and see) that these also seemed intended to make the files "accessible" to hand editing, though I'm unsure if that was an intention.
Finally, the last thing I understand from what you were doing is you were cleaning up the names and "concepts" in some of the files. Obviously this is not handled here.
(Anyway these changes I think are needed and good, so I'm not blocked by your reply, so take your time. Though I want to understand the needs you had, to handle them.)