Skip to content
This repository was archived by the owner on Jun 28, 2025. It is now read-only.

Conversation

Steinhagen
Copy link
Contributor

@Steinhagen Steinhagen commented Apr 30, 2024

The KDE Matrix room icon was added as a layer to the room template. The colors used were selected to be unique and as close to the KDE project as possible.

This commit also replaces the default Matrix room globe png with it's correct svg image taken from their SDK.

The KDE Matrix room icon was added as a layer to the room template.
The colors used were selected to be unique and as close to the KDE
project as possible.

This commit also replaces the default Matrix room globe png with it's
correct svg image taken from their SDK.
@Steinhagen Steinhagen force-pushed the add-kde-matrix-icon branch from fc651ba to 4940c9b Compare May 1, 2024 07:36
@Steinhagen Steinhagen changed the title Added KDE Matrix room icon Add KDE Matrix icon + replace template room png with svg May 1, 2024
@Lassulus
Copy link
Member

the planet still looks kinda weird, but it's surely a huge improvement :)

@Lassulus Lassulus merged commit dc096b1 into NixOS:master Sep 26, 2024
@SigmaSquadron
Copy link
Contributor

SigmaSquadron commented Sep 26, 2024

This PR was very messy and edited a bunch of things it really shouldn't have. A normal-looking matrix icon PR would be #136 or #137, which just adds the new layers and doesn't re-format the entire file. Both of these now have merge conflicts because of the new formatting.

A good way to prevent Inkscape from doing this is to use the Nixpkgs revision that builds the icons to run Inkscape, and then manually patch out the few formatting changes that the old version of Inkscape makes.

Well, I guess the silver lining is that we'll have smaller diffs when the file is edited with a modern Inkscape going forward.

@Steinhagen
Copy link
Contributor Author

I wasn't aware that we should've used the 'matrix/pkgs.nix' Inkscape version. Will the revisions in that file be updated to reflect the version used for our svg? Also, is there any documentation on how to patch the formatting changes? If there isn't, I think it would be wise to have this documented somewhere.

@SigmaSquadron
Copy link
Contributor

Yeah we probably should have a README for matrix icons. Samuel used to manage this repo, but since he left Nixpkgs, the knowledge of how to properly add new icons has gone with him. The old inkscape thing is pretty much a hack.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants