Skip to content

Conversation

@frenetic00
Copy link
Contributor

Description of changes

Adds package for libedgetpu which is the user space driver for Coral devices.
Fixes #188719

The package is based on derivations that have been posted in issue #188719
The derivation applies a patch to the Makefile which allows the library to be built with newer versions of Tensorflow and Flatbuffers.

This as been tested and works with Frigate 0.13.2

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Sep 22, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 22, 2024
@frenetic00 frenetic00 marked this pull request as draft September 24, 2024 08:24
@frenetic00 frenetic00 marked this pull request as ready for review September 24, 2024 08:29
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash into two commits:

  1. maintainers: add frenetic00
  2. libedgetpu: init at 0-unstable-2024-03-14

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 25, 2024
@frenetic00 frenetic00 marked this pull request as draft September 25, 2024 17:49
@frenetic00 frenetic00 marked this pull request as ready for review September 26, 2024 08:34
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 26, 2024
@VTimofeenko
Copy link
Contributor

Works perfectly with frigate from 24.05 and usb-c coral

@Aleksanaa Aleksanaa merged commit d20a6ca into NixOS:master Nov 1, 2024
@naggie
Copy link
Contributor

naggie commented Nov 1, 2024

Thank you so much @frenetic00 @Aleksanaa !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

libedgetpu: package and provide nixos module

5 participants