Skip to content

intel-graphics-compiler: fix build with cmake 4 #449133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuperSandro2000 merged 1 commit into from
Oct 7, 2025
Merged

intel-graphics-compiler: fix build with cmake 4 #449133

SuperSandro2000 merged 1 commit into from
Oct 7, 2025

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 6, 2025 •
edited
Loading

Closes #448304

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Oct 6, 2025
Closed
3 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 6, 2025
@SuperSandroBot

This comment was marked as outdated.

Sign in to view
@Frontear
Copy link
Member

Frontear commented Oct 6, 2025

Failing to build because the GitHub PR's commit changed (author force pushed). It's probably better to either wait for the PR to merge and then use the revision directly, or download the patch in-tree.

Frontear
Frontear suggested changes Oct 6, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 6, 2025
@liff

This comment was marked as outdated.

Sign in to view
@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Oct 7, 2025

tested locally and it builds

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Oct 7, 2025
Merged via the queue into NixOS:master with commit abc88e8 Oct 7, 2025
27 of 31 checks passed
@SuperSandro2000 SuperSandro2000 deleted the igc-cmake4 branch October 7, 2025 14:17
@SuperSandroBot
Copy link

SuperSandroBot commented Oct 7, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449133
Commit: ac194b0e0dd1ad78620bb77c31c6ca54b6ef8caf (subsequent changes)
Merge: c95b32cb18fc3b841cd7790d132506c9ac7c934b

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/18313425523

x86_64-linux

✅ 5 packages built:
  • intel-compute-runtime
  • intel-compute-runtime-legacy1
  • intel-compute-runtime-legacy1.drivers
  • intel-compute-runtime.drivers
  • intel-graphics-compiler

aarch64-linux

✅ 1 package built:
  • intel-graphics-compiler

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@panchoh panchoh mentioned this pull request Oct 7, 2025
Open
@josh-sukheja
Copy link

josh-sukheja commented Oct 9, 2025

Should this also fix the build for intel-compute-runtime-legacy1? I assume yes, but would just like to check.

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Oct 9, 2025

Seems like it https://hydra.nixos.org/job/nixpkgs/trunk/intel-compute-runtime-legacy1.x86_64-linux

nukdokplex added a commit to nukdokplex/ncaa that referenced this pull request Oct 10, 2025
@nukdokplex
intel-graphics-compiler: fix build with cmake 4
85bb6f7 
adoptation of NixOS/nixpkgs#449133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Frontear Frontear Frontear requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: intel-graphics-compiler

5 participants

@SuperSandro2000 @SuperSandroBot @Frontear @liff @josh-sukheja