Spectrum index lookup table bug fix. #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lilferrit
force-pushed
the
indexing-fix
branch
from
f909ed0 to
6894c9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As kindly pointed out in #13, the code responsible for generating the spectrum index -> (file, file_index) lookup table behaves incorrectly if more than one file is used in a
SpectrumDataset, since the original code would only index spectra up to the number of spectra in the last file in the dataset, because of the incorrect usage ofoffsetsoverself._file_offsets.There was an additional off by one error caused by adding two 0's to the beginning of the offset array instead of just one.