-
Notifications
You must be signed in to change notification settings - Fork 0
[Hotfix/#9] : 온보딩 UI / 프로필 수정 오류 해결 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gaeulzzang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
허거덩거덩스 오랜만에 안드 코드 보니까 하나도 모르겠네 shit~
| contentScale = ContentScale.FillWidth, | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .background(NoostakTheme.colors.gray100) | ||
| .wrapContentWidth(Alignment.CenterHorizontally) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: contentScale은 뭐고 wrapContentWidth는 뭐에여.. 진짜 컴포즈 1도 모르겠다 xiang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3 : 엄마 그렇게 말하면 어떠케여
| .fillMaxSize() | ||
| .background(NoostakTheme.colors.white), | ||
| .background(NoostakTheme.colors.white) | ||
| .verticalScroll(rememberScrollState()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: LazyColumn 안쓴 나머지 페이지들은 다 verticalScroll 넣어줘야되나.... 근데 그런 페이지 없겠쥬?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: 에뮬레이터로 확인할때 딱히 문제있는 페이지는 없었슴다ㅏㅏ
Eonji-sw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
누스탁 오랜만
kt 코드 진짜 오랜만에 보니까 너무 재밌네; 나 개발 좋아했었네;
| contentScale = ContentScale.FillWidth, | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .background(NoostakTheme.colors.gray100) | ||
| .wrapContentWidth(Alignment.CenterHorizontally) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3 : 엄마 그렇게 말하면 어떠케여
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3 : 화면 안넘어가는게 UI 문제였던건가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: 온보딩 이미지 크기 때문에 밑에가 잘리는 문제가 있었습니다!
| _nickname.value = memberName | ||
| _profileImage.value = memberProfileImage ?: "" | ||
| _userProfileState.update { | ||
| it.copy( | ||
| memberName = memberName, | ||
| memberProfileImage = memberProfileImage | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2 : 하암.. 슬퍼 로그아웃하고 새로 로그인하면 로컬 데이터가 초기화되는건가? 만약 초기화되는 문제라면 저장 프로세스 추가해서 데이터 안 덮어씌워도 되려나?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
새로 설치 및 캐시 데이터 삭제 후 기존 아이디로 로그인하면 데이터를 못 불러와서 빈값으로 적용되드라구..
마이페이지에서 전달하는 매개변수로 초기화하게 바꿨슈
✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁
📌 𝗜𝘀𝘀𝘂𝗲𝘀
📎 𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻
📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁
💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀
UI랑 데이터 초기화 방식만 변경했습니다!