Skip to content

Conversation

@sdelgadoc
Copy link
Contributor

No description provided.

@kwilsonmg
Copy link
Contributor

kwilsonmg commented Nov 18, 2025

I think that this is a cool concept, but perhaps it could be extended to work for folders other than inbox as is currently hardcoded? I think that that would make it more extensible/useful. What are your thoughts, @sdelgadoc?

Edit: I see that sdelgadoc is potentially inactive. @alejcas what are your thoughts on this PR as a whole? If it's accepted I would be happy to put in a PR then doing the above.

@sdelgadoc
Copy link
Contributor Author

Hey @kwilsonmg, I never finished this, but still find it useful to implement. There's also some ways I've figured out how to make it more robust. If @alejcas and you would find it useful, I could finish it and submit. Let me know!

@kwilsonmg
Copy link
Contributor

I have immediate use cases in mind as well for a feature like this. Curious alejcas' thoughts. I would love to see this completed.

@alejcas
Copy link
Member

alejcas commented Nov 19, 2025

This should be on it's own file (subscriptions.py) and be accessible through the account object. A subscription can be set to any ms graph element. I would like to merge it but not in it's current state.

@sdelgadoc
Copy link
Contributor Author

Thanks @alejcas, your architectural suggestion makes sense. Give me a few days and I'll send out a PR with the changes for @kwilsonmg and you to test and review.

@sdelgadoc sdelgadoc marked this pull request as ready for review November 20, 2025 21:04
@sdelgadoc
Copy link
Contributor Author

Hey @alejcas and @kwilsonmg, please find here completed the PR to add subscriptions and notifications to the library. I added an example to demonstrate usage, and for testing. Let me know if you have any questions or edits. Otherwise, this is ready to merge.

@alejcas
Copy link
Member

alejcas commented Nov 21, 2025

I can merge it as it is although it lacks:

  • list subscriptions
  • get subscription
  • update subscription

At least the list method should be available.
But as said I can merge this and latter on improve. As you want.

@sdelgadoc sdelgadoc changed the title Add email receipt notifications through webhooks Add generic notification subscriptions through webhooks Nov 21, 2025
@sdelgadoc
Copy link
Contributor Author

Thanks @alejcas. I think that adding the three endpoints you listed is reasonable. However, with the holidays coming up, I will likely not be able to start implementing until early to mid December. So, depending on @kwilsonmg and other users' timeline, we can either merge this PR to give folks basic functionality, and I can add the additional endpoints later, or wait and merge all the functionality together in a few weeks. Either works for me.

@kwilsonmg
Copy link
Contributor

kwilsonmg commented Nov 22, 2025

This is certainly a "nice to have" for the library, but I can honestly wait a while longer. I'm not in a huge rush, just excited by the possibilities this will all unlock once completed. (TLDR: I'm indifferent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants