Skip to content

v3.1.2: Clarify that Request Body Objects need a body #4614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2025
Merged

v3.1.2: Clarify that Request Body Objects need a body #4614

merged 2 commits into from
May 20, 2025

Conversation

handrews
Copy link
Member

Fixes:

We require the Request Body Object's content but failed to require it to be non-empty, even though a request body without a body does not make any sense.

  • schema changes are included in this pull request
  • schema changes are needed for this pull request but not done yet
  • no schema changes are needed for this pull request

@handrews
Clarify that Request Body Objects need a body
70274dc 
We require `content` but failed to require it to be non-empty,
even though a request body without a body does not make any sense.
@handrews handrews added this to the v3.1.2 milestone May 18, 2025
@handrews handrews requested review from a team as code owners May 18, 2025 16:36
@handrews handrews added clarification requests to clarify, but not change, part of the spec media and encoding Issues regarding media type support and how to encode data (outside of query/path params) labels May 18, 2025
miqui
miqui previously approved these changes May 18, 2025
View reviewed changes
ralfhandl
ralfhandl reviewed May 19, 2025
View reviewed changes
Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, just one typo

@handrews @ralfhandl
Fix capitalization
a200ab6 
Co-authored-by: Ralf Handl <[email protected]>
@ralfhandl ralfhandl requested review from a team and miqui May 19, 2025 19:50
@handrews
Copy link
Member Author

I'm going to merge this as @miqui 's approval only got dropped b/c of a typo fix. So there are two TSC approvals here.

@handrews handrews merged commit b376a1d into OAI:v3.1-dev May 20, 2025
2 checks passed
@handrews
Copy link
Member Author

Note- I will batch up the recent 3.1.2 PRs into a single 3.2 sync PR to avoid too much noise in the PR list.

@karenetheridge
Copy link
Member

Ideally we should add a "minProperties": 1 to the schema and change this to "MUST have at least one media-type", but I recognize that that would break backwards compatibility and so we can't do it until 4.x.

@ralfhandl ralfhandl mentioned this pull request Jun 15, 2025
Merged
3 tasks
handrews added a commit that referenced this pull request Jun 15, 2025
@handrews
Merge pull request #4726 from handrews/req-content-320
4972cc0 
v3.2: (port of #4614) Clarify that Request Body Objects need a body
@handrews handrews deleted the req-content branch June 19, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralfhandl ralfhandl ralfhandl approved these changes

@miqui miqui Awaiting requested review from miqui

Assignees
No one assigned
Labels
clarification requests to clarify, but not change, part of the spec media and encoding Issues regarding media type support and how to encode data (outside of query/path params)
Projects
None yet
Milestone
v3.1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@handrews @karenetheridge @ralfhandl @miqui