v3.2: Update Set-Cookie example for recent changes #4903
+28
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to our understanding of percent-encoding and headers have made the previous example incorrect. This brings it into agreement with the new recommendations. This also explains how percent-encoding and other escaping is handled, and links to the updated Appendix D which provids more detail including a link to the IETF draft update of the cookie RFC that clarifies this.
handrews
added
examples
baywet
reviewed
Aug 21, 2025
lornajane
reviewed
Aug 21, 2025
| ``` | ||
| In an HTTP message, the serialized example with Expires would look like: | ||
| In an HTTP message, the serialized example would look like: |
There was a problem hiding this comment.
I don't think I understand why the urlSafeData isn't in the following example
3 tasks
Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: Karen Etheridge <[email protected]>
handrews
commented
Aug 21, 2025
| ``` | ||
| In an HTTP message, the serialized example with Expires would look like: | ||
| In an HTTP message, the serialized example would look like: |
|
@lornajane I have fixed the example and added a note with further explanation about why this looks different from "Hello, world!" in the cookie input parameter example from PR #4902. @karenetheridge as with the other PR, I will gladly approve a PR changing the formatting for |
ralfhandl
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to our understanding of percent-encoding and headers have made the previous example incorrect. This brings it into agreement with the new recommendations.
This also explains how percent-encoding and other escaping is handled, and links to the updated Appendix D which provids more detail including a link to the IETF draft update of the cookie RFC that clarifies this.