Skip to content

v3.2 schema edits #4957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: v3.2-dev
Choose a base branch
from
Open

v3.2 schema edits #4957

wants to merge 9 commits into from

Conversation

karenetheridge
Copy link
Member

Several schema improvements for v3.2. One of them MUST be in the release, as it allows for the use of in: cookie, style: cookie that was prohibited before.

I will backport to v3.1 the things that are relevant there.

  • schema changes are included in this pull request

@karenetheridge karenetheridge requested review from a team as code owners September 15, 2025 19:17
@karenetheridge karenetheridge added the Schema changes related to the schema(s) label Sep 15, 2025
@karenetheridge karenetheridge added this to the v3.2.0 milestone Sep 15, 2025
@karenetheridge
remove redundant "requires"
9ac8910 
- "in" is always required for "parameter"
- "type" is required for "security-scheme"
@karenetheridge
whitespace
c4673bc
@karenetheridge
remove confusing use of json within yaml
c602ca6
@karenetheridge karenetheridge force-pushed the ether/v3.2-schema-remnants branch from b1376fa to 1b20dbc Compare September 15, 2025 19:25
ralfhandl
ralfhandl requested changes Sep 15, 2025
View reviewed changes
Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case pass/path_item_servers_parameters.yaml fails with these schema changes.

@karenetheridge karenetheridge mentioned this pull request Sep 15, 2025
Open
1 task
@karenetheridge karenetheridge force-pushed the ether/v3.2-schema-remnants branch from 1b20dbc to 39cca69 Compare September 15, 2025 20:40
@karenetheridge
Copy link
Member Author

Thanks, I've fixed the test failure.

ralfhandl

This comment was marked as resolved.

Sign in to view

@ralfhandl ralfhandl self-requested a review September 15, 2025 20:54
ralfhandl
ralfhandl previously approved these changes Sep 15, 2025
View reviewed changes
@ralfhandl ralfhandl requested a review from a team September 15, 2025 20:57
@karenetheridge
Copy link
Member Author

style is not required in the parameter object: it's disallowed when combined with content, and style can be omitted to allow its default value to be used in lieu.

@karenetheridge karenetheridge force-pushed the ether/v3.2-schema-remnants branch from 0a03cfc to 2d201d6 Compare September 16, 2025 05:20
@karenetheridge
Copy link
Member Author

I edited the querystring commit to add:

  • the same constraint added for parameters in path-item as operation
  • disallowed more than one querystring

Because of the restrictions appearing in two places (path-item and operation) I created a new definition for parameters.

@karenetheridge karenetheridge force-pushed the ether/v3.2-schema-remnants branch from 2d201d6 to 2463bd0 Compare September 16, 2025 05:40
@ralfhandl ralfhandl requested a review from a team September 16, 2025 07:09
@karenetheridge
Copy link
Member Author

I found one more thing to add, but I'll make a new PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralfhandl ralfhandl ralfhandl approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Schema changes related to the schema(s)
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@karenetheridge @ralfhandl