Skip to content

Conversation

karenetheridge
Copy link
Member

@karenetheridge karenetheridge commented Sep 15, 2025

  • clarify other prohibited combinations of query and querystring

  • clarify that the styles table is comprehensive: other combinations are prohibited

  • markup improvement to the styles table

  • removal of json-like formatting in literal yaml examples of dataValues

  • no schema changes are needed for this pull request

That is, these are also prohibited:

- "query" appearing in the path-item's parameters and "querystring" in
the operation's parameters
- "querystring" appearing in the path-item's parameters and "query" appearing
in the operation's parameters
- Literal style names are now rendered in sans-serif as code
- "primitive" is not rendered as code, as it refers to one of string,
number, boolean or null, not a literal type name.
@karenetheridge karenetheridge requested review from a team as code owners September 15, 2025 20:04
@karenetheridge karenetheridge changed the base branch from main to v3.2-dev September 15, 2025 20:04
@karenetheridge karenetheridge added this to the v3.2.0 milestone Sep 15, 2025
This does not change the actual values of the examples, but it's more clear
that this is literal data being modelled in the schema.
ralfhandl
ralfhandl previously approved these changes Sep 15, 2025
@ralfhandl ralfhandl requested a review from a team September 15, 2025 20:45
mikekistler
mikekistler previously approved these changes Sep 16, 2025
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@ralfhandl ralfhandl dismissed stale reviews from mikekistler and themself via 259ea07 September 16, 2025 11:03
@ralfhandl
Copy link
Contributor

Resolved conflict due to adjacent line changed by merging

@mikekistler Please re-approve

@ralfhandl ralfhandl requested a review from a team September 16, 2025 11:06
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving.

@ralfhandl ralfhandl merged commit 5f38d1d into OAI:v3.2-dev Sep 16, 2025
2 checks passed
@karenetheridge karenetheridge deleted the ether/v3.2-spec-markup branch September 17, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants