Skip to content

main: Fix broken links in 3.2.0.md #4979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2025
Merged

main: Fix broken links in 3.2.0.md #4979

merged 2 commits into from
Sep 28, 2025

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Sep 20, 2025 •
edited
Loading

Fixing this broken link will not make visible changes to the rendered spec and will only avoid a 404 when clicking on the link.

I think this change does not justify a 3.2.1 release and leaving 3.2.0 broken forever.

  • no schema changes are needed for this pull request

@ralfhandl ralfhandl requested a review from a team as a code owner September 20, 2025 17:49
handrews
handrews previously approved these changes Sep 20, 2025
View reviewed changes
Copy link
Member

@handrews handrews left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this fits with the precedents of having fixed broken links on main manually multiple times in the past, including:

@ralfhandl ralfhandl changed the title Hot fix: Repair broken link in 3.2.0.md Hot fix on main: Repair broken link in 3.2.0.md Sep 20, 2025
@ralfhandl ralfhandl changed the title Hot fix on main: Repair broken link in 3.2.0.md main: Fix broken link in 3.2.0.md Sep 20, 2025
karenetheridge
karenetheridge previously approved these changes Sep 20, 2025
View reviewed changes
miqui
miqui previously approved these changes Sep 21, 2025
View reviewed changes
@handrews
Copy link
Member

[omg "precedents" not "precedence"... how tired was I when I wrote that? 🤦]

@ralfhandl ralfhandl marked this pull request as draft September 23, 2025 17:51
@ralfhandl
Copy link
Contributor Author

More links are broken, see

@ralfhandl ralfhandl dismissed stale reviews from handrews, miqui, and karenetheridge via a36ae6b September 24, 2025 14:12
@ralfhandl ralfhandl marked this pull request as ready for review September 24, 2025 14:16
@ralfhandl ralfhandl requested review from handrews, miqui and a team September 24, 2025 14:17
@ralfhandl ralfhandl changed the title main: Fix broken link in 3.2.0.md main: Fix broken links in 3.2.0.md Sep 24, 2025
@baywet baywet mentioned this pull request Sep 25, 2025
Open
@lornajane
Copy link
Contributor

I note that the build failure is expected - it is flagging that the edit is to the versions file which we normally don't edit, but this time we are.

lornajane
lornajane approved these changes Sep 28, 2025
View reviewed changes
Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, also checked it with a link checking tool!

@lornajane lornajane merged commit 815732d into main Sep 28, 2025
3 of 4 checks passed
@lornajane lornajane deleted the ralfhandl-patch-5 branch September 28, 2025 20:27
@ralfhandl
Copy link
Contributor Author

checked it with a link checking tool

@lornajane Which tool did you use? Can we add it to our markdown linting script?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lornajane lornajane lornajane approved these changes

@karenetheridge karenetheridge karenetheridge approved these changes

@handrews handrews Awaiting requested review from handrews

@miqui miqui Awaiting requested review from miqui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ralfhandl @handrews @lornajane @karenetheridge @miqui